[ADD] estate: adding new estate module #727
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
SergeBayet
suggested changes
Apr 22, 2025
estate/__init__.py
Outdated
| @@ -0,0 +1 @@ | |||
| from . import models | |||
There was a problem hiding this comment.
Missing blank line at the end of your file.
estate/__manifest__.py
Outdated
| 'depends': [ | ||
| 'base', | ||
| ] | ||
| } |
estate/models/estate_property.py
Outdated
| garden_area = fields.Integer() | ||
| garden_orientation = fields.Selection( | ||
| string='Orientation', | ||
| selection=[('north','North'), ('south','South'), ('east', 'East'), ('west', 'West')] |
There was a problem hiding this comment.
Suggested change
| selection=[('north','North'), ('south','South'), ('east', 'East'), ('west', 'West')] | |
| selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')] |
Add manifest and dependencies...
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
fd89ef7 to
0b23021
Compare
SergeBayet
suggested changes
Apr 22, 2025
|
@naja628 For you :) |
naja628
reviewed
Apr 25, 2025
estate/models/estate_property.py
Outdated
| name = fields.Char(required=True) | ||
| description = fields.Text() | ||
| postcode = fields.Char() | ||
| date_availability = fields.Date(copy=False, default=du.add(date.today(), months=3)) |
There was a problem hiding this comment.
Here date.today() will be evaled once when the whole class is evaled (i.e. everytime you launch odoo i think).
When it needs to be re-evaled everytime you create new records you can pass a lambda or function to the default kwarg instead
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
d06d33d to
313ec7d
Compare
Added a functional module to create new listings following all the chapter 5 guidelines.
Chapter 6 views: search, list, form done
Repo now is up to date with chapter 7
Added an onchange field and some compute fields, following Chapter 8 rules. Also refactored different views to separate them
Added actions as mentioned in chapter 9 did some refactoring to follow latest comments
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
313ec7d to
3a9a5a2
Compare
Added constraints to follow chapter 10 Refactored to fix a bug in chapter 9
Made some adjustments to follow chapter 11 guidelines
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
3108bd3 to
6316118
Compare
Repo now represents edits made to follow chapter 12 guidelines, inherited view and class created and CRUD modifications were made
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
1688c2c to
6f9cc29
Compare
estate_account linking module created, now follows chapter 13 guidelines
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
99c4242 to
3c56016
Compare
naja628
reviewed
Apr 30, 2025
| def create(self, vals): | ||
| for val in vals: | ||
| single_property = self.env["estate.property"].browse(val["property_id"]) | ||
| if val["price"] < single_property.best_price: |
There was a problem hiding this comment.
here price may not always be in the vals. You could use .get
Guidelines follow chapter 14
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
0a1d15b to
203b4b9
Compare
amry-odoo
force-pushed
the
18.0-tutorial-estate-amry
branch
from
45f1d4e to
bbd1d95
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add manifest and dependencies...