orma - Technical Training #723
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ZorbMax
force-pushed
the
18.0-training-orma
branch
from
b27d320 to
1c46589
Compare
vava-odoo
reviewed
Apr 23, 2025
|
And good point for the green runbot 👏 |
ZorbMax
force-pushed
the
18.0-training-orma
branch
from
1a3faf9 to
d9c0c94
Compare
ZorbMax
force-pushed
the
18.0-training-orma
branch
from
d9c0c94 to
8c9faaa
Compare
vava-odoo
reviewed
Apr 28, 2025
naja628
reviewed
Apr 28, 2025
There was a problem hiding this comment.
Hello :) -- Great work !
[You get 2 2nd review because we got confused :) -- more feedback 🎉 ]
If I go to your runbot and try to install the `estateg module I get an error. You will probably get it locally too if you try to install a new database. (hint: it will be an order of definitions thing probably)
I left a few other comments on your code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.