[ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules by kiga-odoo · Pull Request #237 · odoo/tutorials

kiga-odoo · 2025-01-22T08:21:52Z

module: event_ticket_registration_limit

add a new field to event.event.ticket as max_tickets_per_registration
to limit the number of tickets per registration.
alter event.event_event_ticket_view_tree_from_event and
website.website_event.modal_ticket_registration views to add the field

task-4504632

module: website_appointment_filters

add a module to filter the appointments on website
filters:
- mode [all/online/offline]
- type [all/paid/free]
- schedule [all/resources/users]

task-4505947

module: sale_extension

add wizard to list order lines to distribute the cost

task-4496358

robodoo · 2025-01-22T08:21:54Z

…tion - add a new field to `event.event.ticket` as `max_tickets_per_registration` to limit the number of tickets per registration. - alter `event.event_event_ticket_view_tree_from_event` and `website.website_event.modal_ticket_registration` views to add the field task-4504632

- add a module to filter the appointments on website - filters: - mode [all/online/offline] - type [all/paid/free] - schedule [all/resources/users] task-4505947

…lines - add wizard to list order lines to distribute the cost task-4496358

adsh-odoo

Hello @kiga-odoo
Some comments
Thanks!!

adsh-odoo · 2025-01-29T12:33:24Z

website_appointment_filters/__manifest__.py

+        A sample module to add filters in Appointment Website View
+    """,
+
+    'application': True,


I think no need for this

adsh-odoo · 2025-01-29T12:34:46Z

website_appointment_filters/views/appointment_templates_appointment_filters.xml

+    <template id="website_calendar_index_topbar_mode_filter" name="Filter by Mode" inherit_id="website_appointment.website_calendar_index_topbar">
+        <xpath expr="//t[@t-call='website.website_search_box_input']" position="before">
+            <t t-set="selected_mode" t-value="mode" />
+            <div class="dropdown d-none d-lg-block">


Why d-none d-lg-block?

adsh-odoo · 2025-01-29T12:37:21Z

website_appointment_filters/views/appointment_templates_appointment_filters.xml

+
+    <template id="website_calendar_index_topbar_mode_filter" name="Filter by Mode" inherit_id="website_appointment.website_calendar_index_topbar">
+        <xpath expr="//t[@t-call='website.website_search_box_input']" position="before">
+            <t t-set="selected_mode" t-value="mode" />


Suggested change

<t t-set="selected_mode" t-value="mode" />

<t t-set="selected_mode" t-value="mode" />

Can't we use mode directly instead of assigning it in to a variable
Same for other occurences

adsh-odoo · 2025-01-29T12:57:48Z

website_appointment_filters/controllers/main.py

+        if 'mode' in filters:
+            if filters['mode'] == 'online':
+                for appointment in request.env['appointment.type'].search([('location_id', '=', None)]):
+                    filtered_appointments_by_mode.add(appointment.id)
+            elif filters['mode'] == 'offline':
+                for appointment in request.env['appointment.type'].search([('location_id', '!=', None)]):
+                    filtered_appointments_by_mode.add(appointment.id)
+            elif filters['mode'] == 'all':
+                for appointment in request.env['appointment.type'].search([]):
+                    filtered_appointments_by_mode.add(appointment.id)
+        else:
+            for appointment in request.env['appointment.type'].search([]):
+                filtered_appointments_by_mode.add(appointment.id)
+
+        if 'type' in filters:
+            if filters['type'] == 'paid':
+                for appointment in request.env['appointment.type'].search([('has_payment_step', '=', 'true')]):
+                    filtered_appointments_by_type.add(appointment.id)
+            elif filters['type'] == 'free':
+                for appointment in request.env['appointment.type'].search([('has_payment_step', '!=', 'null')]):
+                    filtered_appointments_by_type.add(appointment.id)
+            elif filters['type'] == 'all':
+                for appointment in request.env['appointment.type'].search([]):
+                    filtered_appointments_by_type.add(appointment.id)
+        else:
+            for appointment in request.env['appointment.type'].search([]):
+                filtered_appointments_by_type.add(appointment.id)
+
+        if 'schedule' in filters:
+            if filters['schedule'] == 'resources':
+                for appointment in request.env['appointment.type'].search([('schedule_based_on', '=', 'resources')]):
+                    filtered_appointments_by_schedule.add(appointment.id)
+            elif filters['schedule'] == 'users':
+                for appointment in request.env['appointment.type'].search([('schedule_based_on', '=', 'users')]):
+                    filtered_appointments_by_schedule.add(appointment.id)
+            elif filters['schedule'] == 'all':
+                for appointment in request.env['appointment.type'].search([]):
+                    filtered_appointments_by_schedule.add(appointment.id)
+        else:
+            for appointment in request.env['appointment.type'].search([]):
+                filtered_appointments_by_schedule.add(appointment.id)


I think we can improve this logic because with current implementation search is called for all the filters one by one.
Instead of that we can prepare domain from getting the values from filter and we make the final search by using that domain.

adsh-odoo · 2025-01-29T13:13:07Z

website_appointment_filters/controllers/main.py

+            filters['type'] = 'all'
+        if 'schedule' not in filters.keys():
+            filters['schedule'] = 'all'
+


unnecessary blank line

adsh-odoo · 2025-01-29T13:27:53Z

website_appointment_filters/views/appointment_templates_appointment_filters.xml

+    <template id="website_calendar_index_topbar_type_filter" name="Filter by Type" inherit_id="website_appointment.website_calendar_index_topbar">
+        <xpath expr="//t[@t-call='website.website_search_box_input']" position="before">
+            <t t-set="selected_type" t-value="type" />
+            <div class="dropdown d-none d-lg-block">
+                <a href="#" role="button" class="btn dropdown-toggle btn-light" data-bs-toggle="dropdown" title="Filter by Type">
+                    Type <span t-if="selected_type != 'all'" t-out="1" class="badge bg-primary ms-1"/>
+                </a>
+                <div class="dropdown-menu">
+                    <span t-att-data-post="'/appointment?%s' % keep_query('*', type='all')" t-attf-class="post_link cursor-pointer dropdown-item d-flex align-items-center justify-content-between #{'active' if selected_type == 'all' else ''}">
+                        All
+                    </span>
+                    <span t-att-data-post="'/appointment?%s' % keep_query('*', type='paid')" t-attf-class="post_link cursor-pointer dropdown-item d-flex align-items-center justify-content-between #{'active' if selected_type == 'paid' else ''}">
+                        Paid
+                    </span>
+                    <span t-att-data-post="'/appointment?%s' % keep_query('*', type='free')" t-attf-class="post_link cursor-pointer dropdown-item d-flex align-items-center justify-content-between #{'active' if selected_type == 'free' else ''}">
+                        Free
+                    </span>
+                </div>
+            </div>
+        </xpath>
+    </template>


Why separate templates for filters i think we can add all the filters in same tempalate.

kiga-odoo force-pushed the 18.0-practice-task-kiga branch 3 times, most recently from 8a40f84 to eb568e1 Compare January 24, 2025 09:48

kiga-odoo force-pushed the 18.0-practice-task-kiga branch from eb568e1 to bdcad1f Compare January 24, 2025 11:28

kiga-odoo added 2 commits January 24, 2025 17:06

[ADD] website_appointment_filter: add module to filter the appointments

69e1a02

- add a module to filter the appointments on website - filters: - mode [all/online/offline] - type [all/paid/free] - schedule [all/resources/users] task-4505947

[ADD] sale_extension: add module to distribute cost over other sales …

4706d7e

…lines - add wizard to list order lines to distribute the cost task-4496358

kiga-odoo force-pushed the 18.0-practice-task-kiga branch from bdcad1f to 4706d7e Compare January 24, 2025 11:37

kiga-odoo changed the title ~~[ADD] event_ticket_registration_limit: add ticket limits per registration~~ [ADD] event_ticket_registration_limit: add ticket limits per registration, Jan 25, 2025

kiga-odoo changed the title ~~[ADD] event_ticket_registration_limit: add ticket limits per registration,~~ [ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules Jan 25, 2025

kiga-odoo changed the title ~~[ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules~~ [ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules Jan 25, 2025

kiga-odoo changed the title ~~[ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules~~ [ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules Jan 25, 2025

adsh-odoo reviewed Jan 29, 2025

View reviewed changes

kiga-odoo closed this Feb 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules#237

[ADD] event_ticket_registration_limit, website_appointment_filters, and sale_extension modules#237
kiga-odoo wants to merge 3 commits intoodoo:18.0from
odoo-dev:18.0-practice-task-kiga

kiga-odoo commented Jan 22, 2025 •

edited

Loading

Uh oh!

robodoo commented Jan 22, 2025

Uh oh!

adsh-odoo left a comment

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

adsh-odoo Jan 29, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

	<t t-set="selected_mode" t-value="mode" />
	<t t-set="selected_mode" t-value="mode" />

Conversation

kiga-odoo commented Jan 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

robodoo commented Jan 22, 2025

Uh oh!

adsh-odoo left a comment

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

adsh-odoo Jan 29, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

kiga-odoo commented Jan 22, 2025 •

edited

Loading