18.0 training aele #232
Open
18.0 training aele #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ethanrobv
reviewed
Jan 21, 2025
estate/models/estate.py
Outdated
| _order = "sequence" | ||
|
|
||
| name = fields.Char('Name', required=True, translate=True) | ||
| description = fields.Text("Description", required=False) |
|
Note the CI/Style check is failing |
nesma-neha
reviewed
Jan 27, 2025
| sequence = fields.Integer() | ||
| # Relations | ||
| property_ids = fields.One2many(comodel_name='estate.property', inverse_name='property_type_id') | ||
| offer_ids = fields.One2many(comodel_name='estate.property.offer', inverse_name='property_type_id') |
There was a problem hiding this comment.
There is no field 'property_type_id' in model 'estate.property.offer'
estate/__manifest__.py
Outdated
| { | ||
| 'name': "Real Estate", | ||
| 'version': '1.0', | ||
| 'depends': ['base', 'mail'], |
estate/models/estate_property.py
Outdated
| class EstateProperty(models.Model): | ||
| _name = "estate.property" | ||
| _description = "Property data model" | ||
| _inherit = ['mail.thread'] |
There was a problem hiding this comment.
Why are you inheriting from mail.threads?
estate/models/estate_property.py
Outdated
Comment on lines
39
to
43
| selection=[('n', 'North'), | ||
| ('s', 'South'), | ||
| ('e', 'East'), | ||
| ('w', 'West'), | ||
| ], |
There was a problem hiding this comment.
Suggested change
| selection=[('n', 'North'), | |
| ('s', 'South'), | |
| ('e', 'East'), | |
| ('w', 'West'), | |
| ], | |
| selection=[ | |
| ('north', 'North'), | |
| ('south', 'South'), | |
| ('east', 'East'), | |
| ('west', 'West'), | |
| ], |
what you did is not wrong but this is the name that will be used in the database so it's better to be more that one character
|
Kindly ensure that you follow the commit message structure outlined in the Odoo documentation: Git Guidelines. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have completed the training CH 1, 2, 3, 4