plha #228
Open
plha #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Great progress so far. 😊 Kindly ensure that you follow the commit message structure outlined in the Odoo documentation: Git Guidelines. |
plha-odoo
force-pushed
the
18.0-tutorials-plha
branch
from
12c851e to
0df9ae8
Compare
nesma-neha
reviewed
Jan 21, 2025
| garden = fields.Boolean() | ||
| garden_area= fields.Integer() | ||
| garden_orientation = fields.Selection([("North","North"),("South","South"),("East","East"),("West","West")]) | ||
|
|
nesma-neha
reviewed
Jan 27, 2025
estate/models/estate_property.py
Outdated
| garden_area= fields.Integer() | ||
| garden_orientation = fields.Selection([("North","North"),("South","South"),("East","East"),("West","West")]) | ||
| active = fields.Boolean(default=True) | ||
| state = fields.Selection([("New","New"),("Offer Received","Offer Received"),("Offer Accpeted","Offer Accepted"),("Solde","Solde"),("Cancelled","Cancelled")],copy=False,default="New") |
There was a problem hiding this comment.
Suggested change
| state = fields.Selection([("New","New"),("Offer Received","Offer Received"),("Offer Accpeted","Offer Accepted"),("Solde","Solde"),("Cancelled","Cancelled")],copy=False,default="New") | |
| state = fields.Selection([ | |
| ("new", "New"), | |
| ("offer_received", "Offer Received"), | |
| ("offer_accepted", "Offer Accepted"), | |
| ("sold", "Sold"), | |
| ("cancelled", "Cancelled") | |
| ], copy=False, default="new") |
| garage = fields.Boolean() | ||
| garden = fields.Boolean() | ||
| garden_area= fields.Integer() | ||
| garden_orientation = fields.Selection([("North","North"),("South","South"),("East","East"),("West","West")]) |
There was a problem hiding this comment.
Suggested change
| garden_orientation = fields.Selection([("North","North"),("South","South"),("East","East"),("West","West")]) | |
| garden_orientation = fields.Selection([("north","North"),("south","South"),("east","East"),("west","West")]) |
Use lowercase keys for state values for consistency with Odoo's best practices.
|
|
||
| property_type_id= fields.Char('Property Offer ID') | ||
| price = fields.Float('Le Prix') | ||
| status = fields.Selection([("Accepted","Accepted"),("Refused","Refused")],copy=False) |
There was a problem hiding this comment.
Suggested change
| status = fields.Selection([("Accepted","Accepted"),("Refused","Refused")],copy=False) | |
| status = fields.Selection([("accepted","Accepted"), ("refused","Refused")], copy=False) |
estate/models/property_offer.py
Outdated
| _name = "estate.property.offer" | ||
| _description = "reals estate properties offer" | ||
|
|
||
| property_type_id= fields.Char('Property Offer ID') |
There was a problem hiding this comment.
Suggested change
| property_type_id= fields.Char('Property Offer ID') | |
| property_offer_id= fields.Char('Property Offer ID') |
misleading name
| from datetime import date, timedelta | ||
|
|
||
| class EstatePropertyType(models.Model): | ||
| _name = "estate.property.tags" |
There was a problem hiding this comment.
Suggested change
| _name = "estate.property.tags" | |
| _name = "estate.property.tag" |
a record represents only one tag
| <field name="type">list</field> | ||
| <field name="arch" type="xml"> | ||
|
|
||
| <list string="Tests"> |
There was a problem hiding this comment.
Suggested change
| <list string="Tests"> | |
| <list string="Property Type List"> |
| <list string="Tests"> | ||
| <field name="name"/> | ||
| <field name="property_type_id"/> | ||
| <field name = "properties" widget="many2many_tags"/> |
There was a problem hiding this comment.
Suggested change
| <field name = "properties" widget="many2many_tags"/> | |
| <field name="properties" widget="many2many_tags"/> |
The properties field uses widget="many2many_tags" in a list view. However, it may not work as intended in this context since list views are for quick overviews, and this widget is more suitable for form views. Consider displaying a count of related properties instead.
| <field name="model">estate.property.types</field> | ||
| <field name="type">form</field> | ||
| <field name="arch" type="xml"> | ||
| <form string="Test"> |
There was a problem hiding this comment.
Suggested change
| <form string="Test"> | |
| <form string="Property Type Form"> |
| <field name="type">search</field> | ||
| <field name="arch" type="xml"> | ||
|
|
||
| <search string="Tests"> |
There was a problem hiding this comment.
Suggested change
| <search string="Tests"> | |
| <search string="Search property type"> |
|
|
||
| <list string="Tests"> | ||
| <field name="name"/> | ||
| <field name="property_type_id"/> |
There was a problem hiding this comment.
Including property_type_id is redundant as the name field already provides a clear identifier for the type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[ADD] first commit of the tutorials of the onboarding