Closed
Conversation
technical training : till ch-8
technical training: till ch-11
technical training: till ch-14
completion of Server Framework 101 with Define module data
Enhance security: Restrict access to properties and invoicing features - Implement security rules to limit access based on user roles (agents, managers). - multi-company support to isolate properties and users by agency. - Bypass access rights for real-estate agents to confirm property sales without invoicing access. - Restrict real-estate agent's access from view and other administrative features.
Implemented 'Add Offer' wizard to streamline the process of making offers on multiple properties at once
…ting - Added a controller to list properties on the website. - Integrated a pager for efficient navigation through property listings. - Improved user experience by enabling seamless browsing of properties.
|
|
adsh-odoo
reviewed
Jan 17, 2025
adsh-odoo
left a comment
adsh-odoo
left a comment
There was a problem hiding this comment.
Hello yame-odoo
Some comments
Thanks!!
| from odoo.http import request | ||
|
|
||
|
|
||
| class Academy(http.Controller): |
There was a problem hiding this comment.
give the name of class something relatable to our usecase
Comment on lines
+1
to
+5
| from odoo import fields, models, api, _ | ||
| from datetime import datetime | ||
| from odoo.exceptions import UserError | ||
| from odoo.exceptions import ValidationError | ||
| from dateutil.relativedelta import relativedelta |
There was a problem hiding this comment.
Suggested change
| from odoo import fields, models, api, _ | |
| from datetime import datetime | |
| from odoo.exceptions import UserError | |
| from odoo.exceptions import ValidationError | |
| from dateutil.relativedelta import relativedelta | |
| from datetime import datetime | |
| from dateutil.relativedelta import relativedelta | |
| from odoo import _, api, fields, models | |
| from odoo.exceptions import UserError, ValidationError |
Generally we first make external imports and then we import from odoo in alphabetical order.
Need to adapt in all files
estate/models/estate_property.py
Outdated
| "res_model": "propery.offers", | ||
| "view_mode": "form", | ||
| "context": { | ||
| "default_property_ids": self.ids, |
There was a problem hiding this comment.
no need for this we can get the selected properties using self.context.get('active_ids')
estate/wizard/property_offers.py
Outdated
| _description = "TransientModelmodel for offers" | ||
|
|
||
| price = fields.Float("price", required=True) | ||
| property_ids = fields.Many2many("estate.property", string="property_id") |
There was a problem hiding this comment.
No need to to link this wizard with estate.property
estate/wizard/property_offers.py
Outdated
Comment on lines
+15
to
+25
| for property in self.property_ids: | ||
| try: | ||
| self.env["estate.property.offer"].create( | ||
| { | ||
| "price": self.price, | ||
| "property_id": property.id, | ||
| "buyer_id": self.buyer_id.id, | ||
| "validity": self.validity, | ||
| } | ||
| ) | ||
| except Exception as e: |
There was a problem hiding this comment.
adapt this implementation using active_ids (refer previous comment)
| "version": "0.1", | ||
| # any module necessary for this one to work correctly | ||
| "depends": ["base", "web", "estate", "account"], | ||
| "application": True, |
There was a problem hiding this comment.
I thinks we remove application="true" because it's bridge and it's ok if it is not there apps filters
Added a computed field book_price to Sales Order Lines and Account Move Lines to display the original product price ("Book Price") based on the selected product
Updated Sales Order Lines list view to include the new "Book Price" field.
Updated Invoice Lines list view (customer invoices only) to include the new "Book Price" field.
- Created Kanban view for budget management - Overrode 'New' button to allow multi-budget creation using a wizard - Clicking on a Kanban card now opens the budget line for the particular budget - Added a menu on budget cards with a 'Configure' button to open the budget form view - Budget line detail opens the Account Analytic Line list - Added validation to trigger a warning or restrict analytic line creation if the budget exceeds the allocated amount
- refactor code
Implemented all OWL features mentioned in Chapter 1. Added tutorials covering hooks, reactivity, and reusable components. Provides a basic understanding of core OWL concepts.
yame-odoo
force-pushed
the
18.0-training-yame
branch
from
5048683 to
de3a200
Compare
Implemented a lazy-loaded dashboard for the JS awesome_dashboard tutorial. Dashboard retrieves data from the awesome_dashboard.statistics service. Displays various numerical data using graphs and cards.
yame-odoo
force-pushed
the
18.0-training-yame
branch
from
de3a200 to
8a9fc09
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create a real estate module for technical training purposes.