Simple Commit for Creating a PR #192

cemalfarukguney · 2024-11-19T09:19:36Z

Simple comment

…ials into 18.0-tutorial-cgun

ushyme

Good work👌🏾. Just a few remarks on formatting/conventions.

There is a general inconsistency in the use of double and single quotes. We tend to use single quotes for technical strings and double quotes for user-facing strings.

ushyme · 2024-11-19T19:14:40Z

.vscode/settings.json

+{
+    "workbench.colorCustomizations": {
+        "activityBar.activeBackground": "#2a4d34",  // Dark green for active background
+        "activityBar.background": "#2a4d34",  // Dark green for background
+        "sash.hoverBorder": "#2a4d34",  // Dark green hover border
+        "statusBar.background": "#1b362e",  // Darker green for status bar
+        "statusBarItem.hoverBackground": "#2a4d34",  // Dark green hover for status bar item
+        "statusBarItem.remoteBackground": "#1b362e",  // Darker green for remote status bar item
+        "titleBar.activeBackground": "#1b362e",  // Dark green for active title bar
+        "titleBar.inactiveBackground": "#1b362e99",  // Dark green for inactive title bar with transparency
+        "tab.activeBorder": "#2a4d34",  // Dark green active tab border
+        "activityBarBadge.background": "#b32d4f",  // Retained red badge background
+        "activityBarBadge.foreground": "#e7e7e7",  // White badge text
+        "activityBar.foreground": "#e7e7e7",  // White activity bar text
+        "activityBar.inactiveForeground": "#e7e7e799",  // Faded white for inactive activity bar
+        "commandCenter.border": "#e7e7e799",  // Light grey border for command center
+        "statusBar.foreground": "#e7e7e7",  // White text for status bar
+        "statusBarItem.remoteForeground": "#e7e7e7",  // White text for remote status bar item
+        "titleBar.activeForeground": "#e7e7e7",  // White text for active title bar
+        "titleBar.inactiveForeground": "#e7e7e799",  // Faded white for inactive title bar
+        "statusBar.debuggingBackground": "#3a2c21",  // Dark brownish-green for debugging status bar
+        "statusBar.debuggingForeground": "#e7e7e7",  // White text for debugging status bar
+        "editorGroup.border": "#2a4d34",  // Dark green for editor group border
+        "panel.border": "#2a4d34",  // Dark green for panel border
+        "sideBar.border": "#2a4d34",  // Dark green for sidebar border
+        "statusBar.border": "#1b362e",  // Dark green for status bar border
+        "statusBar.debuggingBorder": "#3a2c21",  // Dark brownish-green border for debugging status bar
+        "titleBar.border": "#1b362e",  // Dark green for title bar border
+        "folderPathColor.custom1": "#4a6c34",  // Dark olive green for custom folder path 1
+        "folderPathColor.custom2": "#8d5f3f",  // Earthy brown for custom folder path 2
+        "folderPathColor.custom3": "#557e47",  // Medium dark green for custom folder path 3
+        "folderPathColor.custom4": "#5a7d58",  // Muted green for custom folder path 4
+        "folderPathColor.custom5": "#4c9f85"   // Teal green for custom folder path 5
+    }
+
+}


IDE-specific configurations are user-dependent and should not be included in the codebase.

Suggested change

{

"workbench.colorCustomizations": {

"activityBar.activeBackground": "#2a4d34", // Dark green for active background

"activityBar.background": "#2a4d34", // Dark green for background

"sash.hoverBorder": "#2a4d34", // Dark green hover border

"statusBar.background": "#1b362e", // Darker green for status bar

"statusBarItem.hoverBackground": "#2a4d34", // Dark green hover for status bar item

"statusBarItem.remoteBackground": "#1b362e", // Darker green for remote status bar item

"titleBar.activeBackground": "#1b362e", // Dark green for active title bar

"titleBar.inactiveBackground": "#1b362e99", // Dark green for inactive title bar with transparency

"tab.activeBorder": "#2a4d34", // Dark green active tab border

"activityBarBadge.background": "#b32d4f", // Retained red badge background

"activityBarBadge.foreground": "#e7e7e7", // White badge text

"activityBar.foreground": "#e7e7e7", // White activity bar text

"activityBar.inactiveForeground": "#e7e7e799", // Faded white for inactive activity bar

"commandCenter.border": "#e7e7e799", // Light grey border for command center

"statusBar.foreground": "#e7e7e7", // White text for status bar

"statusBarItem.remoteForeground": "#e7e7e7", // White text for remote status bar item

"titleBar.activeForeground": "#e7e7e7", // White text for active title bar

"titleBar.inactiveForeground": "#e7e7e799", // Faded white for inactive title bar

"statusBar.debuggingBackground": "#3a2c21", // Dark brownish-green for debugging status bar

"statusBar.debuggingForeground": "#e7e7e7", // White text for debugging status bar

"editorGroup.border": "#2a4d34", // Dark green for editor group border

"panel.border": "#2a4d34", // Dark green for panel border

"sideBar.border": "#2a4d34", // Dark green for sidebar border

"statusBar.border": "#1b362e", // Dark green for status bar border

"statusBar.debuggingBorder": "#3a2c21", // Dark brownish-green border for debugging status bar

"titleBar.border": "#1b362e", // Dark green for title bar border

"folderPathColor.custom1": "#4a6c34", // Dark olive green for custom folder path 1

"folderPathColor.custom2": "#8d5f3f", // Earthy brown for custom folder path 2

"folderPathColor.custom3": "#557e47", // Medium dark green for custom folder path 3

"folderPathColor.custom4": "#5a7d58", // Muted green for custom folder path 4

"folderPathColor.custom5": "#4c9f85" // Teal green for custom folder path 5

}

}

ushyme · 2024-11-20T07:13:11Z

awesome_kanban/__manifest__.py

+
+#Comment for creating a pull request.


Don't forget to remove this.

ushyme · 2024-11-20T07:14:24Z

estate/__init__.py

@@ -0,0 +1,2 @@
+# -*- coding: utf-8 -*-
+from . import models


Suggested change

from . import models

from . import models

Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems.

ushyme · 2024-11-20T07:15:01Z

estate/models/__init__.py

+from . import estate_property
+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer


Same as before, missing trailing line.

ushyme · 2024-11-20T07:15:24Z

estate/models/estate_property.py

+    offer_ids = fields.One2many('estate.property.offer', 'property_id')
+


Same as before, missing trailing line.

ushyme · 2024-11-20T07:52:59Z

estate/models/estate_property.py

+
+    postcode = fields.Char('Postcode')
+
+    date_availability = fields.Date('Available From', copy=False, default=date.today() + timedelta(days=90))


Suggested change

date_availability = fields.Date('Available From', copy=False, default=date.today() + timedelta(days=90))

date_availability = fields.Date('Available From', copy=False, default=lambda: fields.Date.today() + timedelta(days=90))

With the way things are now, the default date will be calculated only once at the start of the server. To make sure that it is calculated correctly every time it is need, you need to wrap the value inside a function.

for date default values, we prefer to get today's date from fields.Date.today()

also, you can use months=3 instead of days=90,

ushyme · 2024-11-20T08:01:38Z

estate/__manifest__.py

+    # any module necessary for this one to work correctly
+    'depends': ['base'],
+    'application': True,
+    'installable': True,


Suggested change

'installable': True,

installable is true by default.

ushyme · 2024-11-20T08:16:42Z

estate/models/estate_property.py

+    garden_orientation = fields.Selection(
+        string='Garden Orientation',
+        selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
+
+    state = fields.Selection(
+        string='Status',
+        required=True,
+        copy=False,
+        default='new',
+        selection=[('new', 'New'), ('received', 'Offer Received'), ('accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])


nitpick 😄

Suggested change

garden_orientation = fields.Selection(

string='Garden Orientation',

selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])

state = fields.Selection(

string='Status',

required=True,

copy=False,

default='new',

selection=[('new', 'New'), ('received', 'Offer Received'), ('accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')])

garden_orientation = fields.Selection(

string="Garden Orientation",

selection=[

('north', "North"),

('south', "South"),

('east', "East"),

('west', "West"),

],

)

state = fields.Selection(

string="Status",

required=True,

copy=False,

default='new',

selection=[

('new', "New"),

('received', "Offer Received"),

('accepted', "Offer Accepted"),

('sold', "Sold"),

('cancelled', "Cancelled"),

],

)

ushyme · 2024-11-20T08:22:42Z

estate/views/estate_property_views.xml

+                    <field name="living_area"/>
+                    <field name="facades"/>
+                    <separator/>
+                    <filter string="Available" name="available" domain="['|', ('state', '=', 'new'), ('state', '=', 'received')]"/>


You could also use the in domain operator.

ushyme · 2024-11-20T09:01:19Z

estate/views/estate_property_tag_views.xml

+        <field name="name">estate.property.tag.search</field>
+            <field name="model">estate.property.tag</field>
+            <field name="arch" type="xml">
+                <search string="Search Tags">
+                    <field name="name"/>
+                </search>
+            </field>


Suggested change

<field name="name">estate.property.tag.search</field>

<field name="model">estate.property.tag</field>

<field name="arch" type="xml">

<search string="Search Tags">

<field name="name"/>

</search>

</field>

<field name="name">estate.property.tag.search</field>

<field name="model">estate.property.tag</field>

<field name="arch" type="xml">

<search string="Search Tags">

<field name="name" />

</search>

</field>

estate/models/estate_property.py

estate/models/estate_property_offer.py

estate/models/estate_property.py

estate/models/estate_property_offer.py

robodoo · 2024-11-21T08:37:30Z

robodoo · 2024-11-21T08:37:31Z

@cemalfarukguney I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands.

ushyme

Good job. Just a few more remarks.

ushyme · 2024-11-22T08:14:29Z

awesome_kanban/__manifest__.py

 {
-    'name': "Awesome Kanban",
-    'summary': """
+    "name": "Awesome Kanban",
+    "summary": """
        Starting module for "Master the Odoo web framework, chapter 4: Customize a kanban view"
    """,
-
-    'description': """
+    "description": """
        Starting module for "Master the Odoo web framework, chapter 4: Customize a kanban view.
    """,
-
-    'version': '0.1',
-    'application': True,
-    'category': 'Tutorials/AwesomeKanban',
-    'installable': True,
-    'depends': ['web', 'crm'],
-    'data': [
-        'views/views.xml',
+    "version": "0.1",
+    "application": True,
+    "category": "Tutorials/AwesomeKanban",
+    "installable": True,
+    "depends": ["web", "crm"],
+    "data": [
+        "views/views.xml",
    ],
-    'assets': {
-        'web.assets_backend': [
-            'awesome_kanban/static/src/**/*',
+    "assets": {
+        "web.assets_backend": [
+            "awesome_kanban/static/src/**/*",
        ],
    },
-    'license': 'AGPL-3'
+    "license": "AGPL-3",
 }


Consider avoiding formatting-only changes in a file, as they can clutter the commit history and increase the likelihood of merge conflicts.

estate/__init__.py

estate/__manifest__.py

estate/views/estate_salesperson_views.xml

estate/models/estate_property_offer.py

cemalfarukguney added 10 commits November 19, 2024 10:06

Simple Commit for Creating a PR

c593d6b

[REF] Simple Commit for Creating a PR

e05bc7f

Merge branch '18.0-tutorial-cgun' of github.com:cemalfarukguney/tutor…

f44a6e4

…ials into 18.0-tutorial-cgun

Chapter 2 (cgun)

37780a7

Chapter 3 (cgun)

a0f723c

Chapter 4 (cgun)

89481d1

Chapter 5 (cgun)

f60d9ac

Chapter 6 (cgun)

d7a89dd

Chapter 7 (cgun)

c74f6c2

Chapter 8 (cgun)

797dbfc

ushyme reviewed Nov 20, 2024

View reviewed changes

cemalfarukguney added 2 commits November 20, 2024 10:50

Chapter 9 (cgun) - With formatting updates

a9d598a

Chapter 10 (cgun)

a8e1201

ushyme reviewed Nov 21, 2024

View reviewed changes

Delete IDE specific file

15a6c45

cemalfarukguney added 4 commits November 21, 2024 13:08

Chapter 11 and Format Changes (cgun)

1d4f394

Chapter 12 (cgun)

b6eab69

Chapter 13 (cgun)

12efc30

Chapter 14 (cgun)

9939b32

ushyme reviewed Nov 22, 2024

View reviewed changes

cemalfarukguney added 2 commits November 22, 2024 11:43

Changes after remarks

7097d24

Revert unnecessary changes

2707059

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Simple Commit for Creating a PR #192

Simple Commit for Creating a PR #192

cemalfarukguney commented Nov 19, 2024

ushyme left a comment

ushyme Nov 19, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

robodoo commented Nov 21, 2024

robodoo commented Nov 21, 2024

ushyme left a comment

ushyme Nov 22, 2024

		offer_ids = fields.One2many('estate.property.offer', 'property_id')


		postcode = fields.Char('Postcode')

		date_availability = fields.Date('Available From', copy=False, default=date.today() + timedelta(days=90))

Simple Commit for Creating a PR #192

Are you sure you want to change the base?

Simple Commit for Creating a PR #192

Conversation

cemalfarukguney commented Nov 19, 2024

ushyme left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

robodoo commented Nov 21, 2024

robodoo commented Nov 21, 2024

ushyme left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment