18.0 training amah #190

amah-odoo · 2024-11-19T07:58:29Z

No description provided.

robodoo · 2024-11-20T13:30:03Z

robodoo · 2024-11-20T13:30:04Z

@amah-odoo I didn't know about this PR and had to retrieve its information, you may have to re-approve it as I didn't see previous commands.

ushyme

Good work ! Just a few remarks we already talked about.

ushyme · 2024-11-20T15:36:13Z

estate/__manifest__.py

+        'views/estate_menus.xml',
+
+    ],
+    'installable': True,


Suggested change

'installable': True,

installable is true by default

ushyme · 2024-11-20T15:41:57Z

estate/__manifest__.py

+    'name': "Real Estate",
+    'version': '1.0',
+    'depends': ['base'],
+    'author': "Abdelrahman Mahmoud (amah)",


Since you're working for Odoo, you shouldn't sign the module in your personal name. Odoo is the default value, and leaving the author field empty will automatically sign the module under Odoo as required.

ushyme · 2024-11-20T15:43:34Z

estate/models/__init__.py

+from . import estate_property_type
+from . import estate_property_tag
+from . import estate_property_offer
+from . import res_users


Same issue as before (missing trailing line)

ushyme · 2024-11-20T15:46:20Z

estate/__init__.py

@@ -0,0 +1 @@
+from . import models


Remember to leave an empty line at the end of files. While it seems trivial, it ensures compatibility with many tools and version control systems.

ushyme · 2024-11-20T15:46:33Z

estate/views/estate_menus.xml

+
+        </menuitem>
+    </menuitem>
+</odoo>


Same issue as before (missing trailing line)

ushyme · 2024-11-20T18:40:10Z

estate/models/res_users.py

+from odoo import models, fields
+
+
+class InheritedResUsers(models.Model):


Suggested change

class InheritedResUsers(models.Model):

class ResUsers(models.Model):

ushyme · 2024-11-20T19:40:10Z

estate/models/estate_property.py

+    def action_set_offer_received(self):
+        self.state = 'offer_received'


Is there a reason why you wrote this method ?

ushyme · 2024-11-20T19:47:50Z

estate/models/estate_property_offer.py

+    status = fields.Selection([
+        ('accepted', 'Accepted'),
+        ('refused', 'Refused'),
+    ],
+        copy=False,
+    )


Suggested change

status = fields.Selection([

('accepted', 'Accepted'),

('refused', 'Refused'),

],

copy=False,

)

status = fields.Selection(

[

('accepted', 'Accepted'),

('refused', 'Refused'),

],

copy=False,

)

ushyme · 2024-11-20T19:49:13Z

estate_account/__manifest__.py

+    'data': [
+
+        # views
+
+        # menu
+
+    ],


Don't leave empty values.

ushyme · 2024-11-20T19:53:10Z

estate_account/__manifest__.py

+        # menu
+
+    ],
+    'installable': True,


same comment about 'installable'

add the base for manifest

- base of property model - estate.property: the basic fields - estate.property: mark the requird fields

- estate.property: security base file

- estate.property: base view action - estate: base for the menus - estate.property: add some properties to the fields - estate.property: some reserved fields

- estate.property: list, form, search views

- estate: new models type, tag, offer with thier views - estate.property: link with the new created models

- fix some typos in required word - Add the computed fields

- estate.property: actions and buttons to change state - estate.property.offer: actions and buttons to change status

- constrains on prices to be postive - constrains on names to be unique - constrains on selling to be 90% of expected

- list view for the propeties in each type - make the state of the propety as statusbar - list orders for the models - Apply color, invesible, readonly attribute where needed in the views - Change list views to be editable and has color decorations - override filter_domain for the area to be greater than - connection between the type and offers to create a stat button

- override the delete of properties to prevent deletion of in-process ones - make the offer_recivied triggered on creation not onchange - res.users: connection to the estate.property and show them in list in notebook page

- module to likn the estate to accounting - issue an invoice at selling the property

- provide a grouped kanban view for the properties

- rename inhertied files name - reorder the imports - correction attribute order - make action name consistent [REF] estate_account: rename inhertied files name to meet the guidlines

…s not been set

- change the offer creation to override the multi_creation - remove depricated kanban-box template from the properties kanban view

- test the total area calculation - test the selling the property prevent cancelling or creation of new offer

…rientation value

…maller functions

- add agent and manager groups - make the user only sees his own docs

…urity check to stop the bypass - add a bypass to make agent able to make invoice - add security check prog before the sudo to ensure that only agents with write access can bypass the security

…and offers

…ties and from salesman views

- add id to div in estate to locate it using xpath - add a line to indicate that an invoice is isssued if so - fix the access check argument

amah-odoo force-pushed the 18.0-training-amah branch 2 times, most recently from c1f97f8 to bc5b991 Compare November 19, 2024 10:32

ushyme reviewed Nov 21, 2024

View reviewed changes

amah-odoo force-pushed the 18.0-training-amah branch from 45f9d17 to 2b24ecd Compare November 21, 2024 14:30

amah-odoo added 18 commits November 21, 2024 15:33

[ADD] estate: chapter 2

89f8ee8

add the base for manifest

[IMP] estate: Chapter 3

f92dd2b

- base of property model - estate.property: the basic fields - estate.property: mark the requird fields

[IMP] estate: Chapter 4

7c96779

- estate.property: security base file

[IMP] estate: Chapter 5:

8ce98f7

- estate.property: base view action - estate: base for the menus - estate.property: add some properties to the fields - estate.property: some reserved fields

[IMP] estate: Chapter 6

e4baa79

- estate.property: list, form, search views

[IMP] estate: Chapter 7

df211bf

- estate: new models type, tag, offer with thier views - estate.property: link with the new created models

[IMP] estate: Chapter 8

958c7af

- fix some typos in required word - Add the computed fields

[IMP] estate: Chapter 9

c5e9053

- estate.property: actions and buttons to change state - estate.property.offer: actions and buttons to change status

[IMP] estate: Chapter 10

8351d41

- constrains on prices to be postive - constrains on names to be unique - constrains on selling to be 90% of expected

[IMP] estate: Chapter 12

1ce2460

- override the delete of properties to prevent deletion of in-process ones - make the offer_recivied triggered on creation not onchange - res.users: connection to the estate.property and show them in list in notebook page

[ADD] estate_account: Chapter 13:

781a5a1

- module to likn the estate to accounting - issue an invoice at selling the property

[IMP] estate: Chapter 14

5d73f5e

- provide a grouped kanban view for the properties

[REF] estate: Chapter 15

b5735dc

- rename inhertied files name - reorder the imports - correction attribute order - make action name consistent [REF] estate_account: rename inhertied files name to meet the guidlines

[IMP] estate_account: fix all Ruff warning

b7c9fdc

[IMP] estate: fix all Ruff warrnings

71465d6

[IMP] estate: apply the style suggestions in my review

30a9a0b

[IMP] estate_account: improve code style compatibility

58e2165

amah-odoo force-pushed the 18.0-training-amah branch from 2b24ecd to 58e2165 Compare November 21, 2024 14:45

amah-odoo added 5 commits November 21, 2024 17:07

[IMP] estate: add the license key in the manifest

3ab7504

[IMP] estate_account: add the license key in the manifest

2853339

[FIX] estate: handel the compute function while the creation date doe…

9d96730

…s not been set

[IMP] estate: solving the python warrnings

feb07dd

- change the offer creation to override the multi_creation - remove depricated kanban-box template from the properties kanban view

[IMP] estate: adding the first test class

872b101

- test the total area calculation - test the selling the property prevent cancelling or creation of new offer

amah-odoo added 2 commits November 22, 2024 10:43

[FIX] estate: onchange garden to set 'north' rather than 'n' in the o…

7e67e95

…rientation value

[IMP] estate: adding the test common class and split the tests into s…

487cb26

…maller functions

amah-odoo force-pushed the 18.0-training-amah branch from 566e7f2 to 487cb26 Compare November 22, 2024 09:50

amah-odoo added 7 commits November 22, 2024 11:56

[IMP] estate: add the security groups and rules

d5c51a9

- add agent and manager groups - make the user only sees his own docs

[IMP] estate_accounting: bypass security with sudo() and then add seq…

830e763

…urity check to stop the bypass - add a bypass to make agent able to make invoice - add security check prog before the sudo to ensure that only agents with write access can bypass the security

[IMP] estate: settings menu is shown only for the managers

1580954

[IMP] estate: make the property company specefic

670e7f4

[IMP] estate: adding data for the types and demo data for properties …

eed9d89

…and offers

[IMP] estate: add basic reports to show properties offers from proper…

34b3851

…ties and from salesman views

[IMP] estate_account: extend the property report to add invoice data

826c561

- add id to div in estate to locate it using xpath - add a line to indicate that an invoice is isssued if so - fix the access check argument

amah-odoo closed this Dec 12, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

18.0 training amah #190

18.0 training amah #190

amah-odoo commented Nov 19, 2024

robodoo commented Nov 20, 2024

robodoo commented Nov 20, 2024

ushyme left a comment

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

ushyme Nov 20, 2024

		from odoo import models, fields


		class InheritedResUsers(models.Model):

	class InheritedResUsers(models.Model):
	class ResUsers(models.Model):

		def action_set_offer_received(self):
		self.state = 'offer_received'

18.0 training amah #190

18.0 training amah #190

Conversation

amah-odoo commented Nov 19, 2024

robodoo commented Nov 20, 2024

robodoo commented Nov 20, 2024

ushyme left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment