Up to chapter 3 by abotaha23 · Pull Request #1199 · odoo/tutorials

abotaha23 · 2026-03-16T12:10:13Z

No description provided.

robodoo · 2026-03-16T12:10:17Z

leclerc-leo

Great job 👍

Try to use more meaningful names and ids which will help other understand your code.

leclerc-leo · 2026-03-16T12:18:39Z

estate/models/estate_property.py

+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+


This isn't needed anymore and can be removed.

leclerc-leo · 2026-03-16T12:19:00Z

estate/__manifest__.py

+# -*- coding: utf-8 -*-
+# Part of Odoo. See LICENSE file for full copyright and licensing details.
+
+


same here, this isn't needed anymore

estate/__manifest__.py

leclerc-leo · 2026-03-16T12:40:18Z

estate/__manifest__.py

+
+{
+    'name': 'Estate',
+    'version': '1.9',


Suggested change

'version': '1.9',

'version': '1.0',

When creating a module, it should be on 1.0.

leclerc-leo · 2026-03-16T12:45:08Z

estate/models/estate_property.py

+from odoo import fields, models
+
+
+class RecurringPlan(models.Model):


A better name for this class would be EstateProperty to match the _name you've set

leclerc-leo · 2026-03-17T09:30:38Z

estate/models/estate_property.py

    description = fields.Text()
    postcode = fields.Char()
-    date_availability = fields.Date()
+    date_availability = fields.Date(default=fields.Date.today()+relativedelta(months=3), copy=False)


You should use a lambda instead of directly giving it a value.
As the value used by default here would be computed when the server starts so if your server ran for 2 months, the date_availability would be only offset by a month.

leclerc-leo · 2026-03-17T09:49:46Z

estate/models/estate_property.py

    garden_area = fields.Integer()
-    garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
+    garden_orientation = fields.Selection(selection=[('north', 'North'), ('south', 'South'), ('east', 'East'), ('west', 'West')])
+    active = fields.Boolean(default=True) # testing the reserved fields thing


Suggested change

active = fields.Boolean(default=True) # testing the reserved fields thing

active = fields.Boolean(default=True)

leclerc-leo · 2026-03-17T09:51:49Z

estate/models/estate_property.py

+    state = fields.Selection(selection=[('new', 'New'), ('offer received', 'Offer Received'), ('offer accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')],
+                            default='new',
+                            required=True,
+                            copy=False
+                        )


Here's how we would format this, Also you should use double quotes for any string that's going to be displayed to the user.

Suggested change

state = fields.Selection(selection=[('new', 'New'), ('offer received', 'Offer Received'), ('offer accepted', 'Offer Accepted'), ('sold', 'Sold'), ('cancelled', 'Cancelled')],

default='new',

required=True,

copy=False

)

state = fields.Selection(

selection=[

('new', "New"),

('offer received', "Offer Received"),

('offer accepted', "Offer Accepted"),

('sold', "Sold"),

('cancelled', "Cancelled"),

],

default='new',

required=True,

copy=False,

)

leclerc-leo · 2026-03-17T09:54:16Z

estate/views/estate_menus.xml

+    <menuitem id="test_menu_root" name="Real Estate">
+        <menuitem id="test_first_level_menu" name="First Level">
+            <menuitem id="test_model_menu_action" action="estate_property_action"/>


Try to use id that represent what is inside.
This will help when you are debugging to identify which one has an issue more easily and will help others that read your code understand it better.

Suggested change

<menuitem id="test_menu_root" name="Real Estate">

<menuitem id="test_first_level_menu" name="First Level">

<menuitem id="test_model_menu_action" action="estate_property_action"/>

<menuitem id="menu_real_estate" name="Real Estate">

<menuitem id="menu_real_estate_first_level" name="First Level">

<menuitem id="menu_real_estate_properties" action="estate_property_action"/>

leclerc-leo · 2026-03-17T09:55:42Z

estate/views/estate_property_views.xml

+        <field name="model">estate.property</field>
+        <field name="arch" type="xml">
+            <list string="Tests">
+                <field name="name" string="Title"/>


Instead of settings string="X" in the view, It's better to set the string="X" on the field directly.
That way, if you display the field in different view, you wont have to add string= in both of those views.

leclerc-leo

🚀

.vscode/settings.json

estate/models/estate_property.py

estate/security/ir.model.access.csv

@@ -0,0 +1,2 @@
+id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
+access_test_model,access_test_model,model_estate_property,base.group_user,1,1,1,1


estate/views/estate_property_offers_views.xml

estate/views/estate_property_types_views.xml

estate/views/estate_property_views.xml

estate_account/__manifest__.py

estate_account/models/estate_property.py

leclerc-leo requested changes Mar 17, 2026

View reviewed changes

abotaha23 force-pushed the 19.0 branch 2 times, most recently from 03a2fed to 6422caa Compare March 19, 2026 09:47

abotaha23 added 13 commits March 20, 2026 09:07

[ADD] estate_property: Up to chapeter 3

333b72f

[ADD] estate_property: Chapter 4

95f4033

[ADD] estate_property: Chapter 5

ce0c008

[ADD] estate_property: Chapter 6

9f0950b

[ADD] estate_property: Chapters 7 and 8

81d3bb9

[ADD] estate_property: Chapter 9

8715319

[ADD] estate_property: Chapter 10

e3a1809

[ADD] estate_property: Chapter 11

f699048

[ADD] estate_property: Chapter 11 enhanced

2ccccfb

[ADD] estate_property: Chapter 12

48b489d

[ADD] estate_property: Chapter 13

1658cf8

[ADD] estate_property: Chapter 14

53b098f

[REF] estate_property: refactoring the code

0c6ac1d

abotaha23 force-pushed the 19.0 branch 5 times, most recently from c4dc2f6 to 4544ecd Compare March 20, 2026 09:51

[REF] estate_module: refactoring the code

26a03f6

abotaha23 force-pushed the 19.0 branch from 4544ecd to 26a03f6 Compare March 20, 2026 10:01

leclerc-leo requested changes Mar 20, 2026

View reviewed changes

[REF] estate_property: did some refactoring

e8dcebe

abotaha23 force-pushed the 19.0 branch from c68ec08 to e8dcebe Compare March 23, 2026 08:02

abotaha23 added 2 commits March 23, 2026 15:14

[ADD] awesome_owl: Chapter 1 in the web framework

fc08cdc

[ADD] awesome_dashboard: Chapter 2 in the web framework

08f9f31

abotaha23 force-pushed the 19.0 branch from 0cb5c69 to 08f9f31 Compare March 25, 2026 13:52

		# -- coding: utf-8 --
		# Part of Odoo. See LICENSE file for full copyright and licensing details.

		from odoo import fields, models


		class RecurringPlan(models.Model):

	active = fields.Boolean(default=True) # testing the reserved fields thing
	active = fields.Boolean(default=True)

		@@ -0,0 +1,2 @@
		id,name,model_id/id,group_id/id,perm_read,perm_write,perm_create,perm_unlink
		access_test_model,access_test_model,model_estate_property,base.group_user,1,1,1,1

Conversation

abotaha23 commented Mar 16, 2026

Uh oh!

robodoo commented Mar 16, 2026

Uh oh!

leclerc-leo left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

leclerc-leo left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as resolved.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants