[IMP] estate: add constraints on some fields

In this commit, I've added api and sql constraints on some of the fields in the property model and the offers model to make sure we don't create a property
with an expected_price less than zero and users don't submit an offer with a price less than zero as well, and added business logic to not accept multiple offers
on the same property at the same time and not to submit an offer on a property that is already sold.

Author: mohannedah

estate/__manifest__.py

@@ -5,12 +5,9 @@
     "data": [
         "security/ir.model.access.csv",
         "views/estate_property_offer_actions.xml",
-        "views/estate_property_actions.xml",
         "views/estate_property_type_actions.xml",
         "views/estate_property_tag_actions.xml",
+        "views/estate_property_actions.xml",
         "views/estate_property_menus.xml",
     ],
-    "application": True,
-    "installable": True,
-    "auto_install": False,
 }

estate/models/estate_property.py

@@ -1,7 +1,8 @@
 import datetime
 
 from odoo import api, fields, models
-from odoo.excepetions import UserError
+from odoo.excepetions import UserError, ValidationError
+from odoo.tools import float_utils
 
 
 class EstateProperty(models.Model):
@@ -41,6 +42,19 @@ class EstateProperty(models.Model):
     offer_ids = fields.One2many("estate.property.offer", "property_id")
     best_offer_price = fields.Float(compute="_compute_best_offer_price")
 
+    _sql_constraints = [
+        (
+            "check_expected_price",
+            "CHECK(expected_price > 0)",
+            "The expected price of a property must be strictly positive.",
+        ),
+        (
+            "check_selling_price",
+            "CHECK(selling_price > 0)",
+            "The selling price of a property must be strictly positive.",
+        ),
+    ]
+
     @api.depends("garden_area", "living_area")
     def _compute_total_area(self):
         for record in self:
@@ -61,6 +75,12 @@ def _onchange_has_garden(self):
                 record.garden_orientation = False
                 record.garden_area = False
 
+    @api.constrains("selling_price")
+    def _check_price(self):
+        for record in self:
+            if float_utils.float_compare(record.selling_price, record.expected_price * 0.9) > 0:
+                raise ValidationError("The selling price cannot be lower than 90%% of the expected price.")
+
     def action_mark_property_as_sold(self):
         if "cancelled" in self.mapped("status"):
             raise UserError("Cannot sell a property that was canceled.")

estate/models/estate_property_offer.py

@@ -14,6 +14,14 @@ class EstatePropertyOffer(models.Model):
     validity_days = fields.Integer(default=7)
     deadline_date = fields.Date(compute="_compute_deadline_date", inverse="_inverse_validity_days")
 
+    _sql_constraints = [
+        (
+            "check_price",
+            "CHECK(price > 0)",
+            "The offer price of a property must be strictly positive.",
+        ),
+    ]
+
     @api.depends("validity_days")
     def _compute_deadline_date(self):
         for record in self:
@@ -27,11 +35,18 @@ def action_accept_offer(self):
         self.ensure_one()
 
         if self.property_id.status == "sold":
-            raise UserError(f"Property with this id {self.property_id} has already been sold.")
+            raise UserError(f"Property with id {self.property_id.id} has already been sold.")
+
+        has_offer_accepted = self.env["estate.property.offer"].search_count(
+            [("status", "=", "accepted"), ("property_id", "=", self.property_id.id)]
+        )
+
+        if has_offer_accepted:
+            raise UserError(f"Property with id {self.property_id.id} has an accepted offer.")
 
         self.status = "accepted"
 
-        self.property_id.action_mark_property_as_sold()
+        # self.property_id.action_mark_property_as_sold()
 
     def action_reject_offer(self):
         for record in self:

estate/models/estate_property_tag.py

@@ -6,3 +6,5 @@ class EstatePropertyTag(models.Model):
     _description = "Estate Property Type"
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [("check_property_tag_name", "unique(name)", "Two property tags cannot have the same name.")]

estate/models/estate_property_type.py

@@ -6,3 +6,5 @@ class EstatePropertyType(models.Model):
     _description = "Estate Property Type"
 
     name = fields.Char(required=True)
+
+    _sql_constraints = [("check_property_type_name", "unique(name)", "Two property types cannot have the same name.")]

estate/views/estate_property_actions.xml

@@ -67,9 +67,7 @@
                         </page>
 
                         <page string="Offers">
-                            <group>
-                                <field name="offer_ids"/>
-                            </group>
+                            <field name="offer_ids"/>
                         </page>
                     </notebook>
                 </sheet>

estate/views/estate_property_offer_actions.xml

@@ -1,24 +1,11 @@
 <?xml version="1.0" encoding="utf-8"?>
 <odoo>
-    <record id="estate_property_offer_list_view" model="ir.ui.view">
-        <field name="name">estate.property.offer.list_view</field>
-        <field name="model">estate.property.offer</field>
-        <field name="arch" type="xml">
-            <list string="Offers">
-                <field name="price"/>
-                <field name="partner_id"/>
-            </list>
-        </field>
-    </record>
-
     <record id="estate_property_offer_form_view" model="ir.ui.view">
         <field name="name">estate.property.offer.form_view</field>
         <field name="model">estate.property.offer</field>
         <field name="arch" type="xml">
             <form string="Property Offer">
                 <sheet>
-                    <button name="action_accept_offer" class="btn-success" string="Accept" type="object"/>
-                    <button name="action_reject_offer" class="btn-danger" string="Reject" type="object"/>
                     <h1 class="mb32">
                         <field name="property_id"/>
                     </h1>
@@ -41,8 +28,8 @@
                 <field name="partner_id"/>
                 <field name="deadline_date"/>
                 <field name="validity_days" string = "Validity"/>
-                <button name="action_accept_offer" type="object" icon="fa-check"/>
-                <button name="action_reject_offer" type="object" icon="fa-times"/>
+                <button name="action_accept_offer" type="object" icon="fa-check" string="accept"/>
+                <button name="action_reject_offer" type="object" icon="fa-times" string="refuse"/>
                 <field name="status"/>
             </list>
         </field>