[IMP] estate: add button actions to offers and property model

In this commit, I've added button actions to easily accept and reject offer, and added the necessary business logic to handle
the different scenarios that might happen while modifying the status of both the offer and the property model. I've modified
some of the code to follow the guidelines.

Author: mohannedah

estate/__manifest__.py

@@ -4,6 +4,7 @@
     "depends": ["base"],
     "data": [
         "security/ir.model.access.csv",
+        "views/estate_property_offer_actions.xml",
         "views/estate_property_actions.xml",
         "views/estate_property_type_actions.xml",
         "views/estate_property_tag_actions.xml",

estate/models/estate_property.py

@@ -1,24 +1,23 @@
 import datetime
 
 from odoo import api, fields, models
+from odoo.excepetions import UserError
 
 
 class EstateProperty(models.Model):
     _name = "estate.property"
     _description = "Estate Property"
+
     name = fields.Char(string="Title")
     seller_id = fields.Many2one(
         "res.users", string="Salesperson", index=True, copy=True, default=lambda self: self.env.user
     )
     description = fields.Text()
     postcode = fields.Char()
     date_availability = fields.Date(
-        default=datetime.datetime.now()
-        + datetime.timedelta(days=90),  # Setting the date availability 3 months from now.
+        default=datetime.datetime.now() + datetime.timedelta(days=90),
         copy=False,
     )
-    validity_days = fields.Integer(default=7)
-    deadline_date = fields.Date(compute="_compute_deadline_date", inverse="_inverse_validity_days")
     expected_price = fields.Float()
     selling_price = fields.Float(readonly=True, copyright=False, copy=False)
     bedrooms = fields.Integer(default=4)
@@ -38,7 +37,7 @@ class EstateProperty(models.Model):
         default="new",
     )
     property_type_id = fields.Many2one("estate.property.type", string="Property type")
-    property_tag_id = fields.Many2many("estate.property.tag", string="Property tag")
+    property_tag_ids = fields.Many2many("estate.property.tag", string="Property tag")
     offer_ids = fields.One2many("estate.property.offer", "property_id")
     best_offer_price = fields.Float(compute="_compute_best_offer_price")
 
@@ -50,21 +49,28 @@ def _compute_total_area(self):
     @api.depends("offer_ids.price")
     def _compute_best_offer_price(self):
         for record in self:
-            record.best_offer_price = max(record.offer_ids.mapped("price")) if record.offer_ids else 0.0
-
-    def _compute_deadline_date(self):
-        for record in self:
-            record.deadline_date = datetime.date.today() + datetime.timedelta(days=record.validity_days)
-
-    @api.depends("deadline_date")
-    def _inverse_validity_days(self):
-        for record in self:
-            record.validity_days = (record.deadline_date - datetime.date.today()).days
+            record.best_offer_price = max(record.offer_ids.mapped("price"), default=0.0)
 
     @api.onchange("has_garden")
     def _onchange_has_garden(self):
         for record in self:
             if record.has_garden:
-                record.garden_orientation, record.garden_area = "north", 10
+                record.garden_orientation = "north"
+                record.garden_area = 10
             else:
-                record.garden_orientation, record.garden_area = None, None
+                record.garden_orientation = False
+                record.garden_area = False
+
+    def action_mark_property_as_sold(self):
+        if "cancelled" in self.mapped("status"):
+            raise UserError("Cannot sell a property that was canceled.")
+
+        for record in self:
+            record.status = "sold"
+
+    def action_mark_property_as_cancelled(self):
+        if "sold" in self.mapped("status"):
+            raise UserError("Cannot cancel a property that was sold.")
+
+        for record in self:
+            record.status = "cancelled"

estate/models/estate_property_offer.py

@@ -1,11 +1,41 @@
-from odoo import fields, models
+import datetime
+from odoo import fields, models, api
+from odoo.exceptions import UserError
 
 
 class EstatePropertyOffer(models.Model):
     _name = "estate.property.offer"
     _description = "Estate Property Offer"
 
     price = fields.Float()
-    status = fields.Selection([("accepted", "Accepted"), ("rejected", "Rejected")], copy=False)
+    status = fields.Selection([("accepted", "Accepted"), ("rejected", "Rejected")], copy=False, readonly=True)
     partner_id = fields.Many2one("res.partner", required=True)
     property_id = fields.Many2one("estate.property", required=True)
+    validity_days = fields.Integer(default=7)
+    deadline_date = fields.Date(compute="_compute_deadline_date", inverse="_inverse_validity_days")
+
+    @api.depends("validity_days")
+    def _compute_deadline_date(self):
+        for record in self:
+            record.deadline_date = datetime.date.today() + datetime.timedelta(days=record.validity_days)
+
+    def _inverse_validity_days(self):
+        for record in self:
+            record.validity_days = (record.deadline_date - datetime.date.today()).days
+
+    def action_accept_offer(self):
+        self.ensure_one()
+
+        if self.property_id.status == "sold":
+            raise UserError(f"Property with this id {self.property_id} has already been sold.")
+
+        self.status = "accepted"
+
+        self.property_id.action_mark_property_as_sold()
+
+    def action_reject_offer(self):
+        for record in self:
+            if record.status == "accepted" and record.property_id.status == "sold":
+                raise UserError(f"Property with id {record.property_id.id} has already been sold.")
+
+            record.status = "rejected"

estate/models/estate_property_tag.py

@@ -3,7 +3,6 @@
 
 class EstatePropertyTag(models.Model):
     _name = "estate.property.tag"
-
     _description = "Estate Property Type"
 
     name = fields.Char(required=True)

estate/models/estate_property_type.py

@@ -3,7 +3,6 @@
 
 class EstatePropertyType(models.Model):
     _name = "estate.property.type"
-
     _description = "Estate Property Type"
 
     name = fields.Char(required=True)

estate/views/estate_property_actions.xml

@@ -19,7 +19,7 @@
                 <field name="selling_price"/>
                 <field name="date_availability"/>
                 <field name="property_type_id"/>
-                <field name="property_tag_id" widget="many2many_tags"/>
+                <field name="property_tag_ids" widget="many2many_tags"/>
             </list>
         </field>
     </record>
@@ -29,19 +29,21 @@
         <field name="model">estate.property</field>
         <field name="arch" type="xml">
             <form string="New Property">
+                <header>
+                    <button name="action_mark_property_as_sold" string="Mark as Sold" type="object" class="btn-primary"/>
+                    <button name="action_mark_property_as_cancelled" string="Cancel" type="object"/>
+                </header>
                 <sheet>
                     <h1 class="mb32">
                         <field name="name"/>
                     </h1>
                     <group>
                         <group>
-                            <field name="property_tag_id" widget="many2many_tags"/>
+                            <field name="property_tag_ids" widget="many2many_tags"/>
                             <field name="seller_id"/>
                             <field name="postcode"/>
                             <field name="property_type_id"/>
                             <field name="date_availability"/>
-                            <field name="deadline_date"/>
-                            <field name="validity_days" string="Validity"/>
                         </group>
                         <group>
                             <field name="expected_price"/>
@@ -86,7 +88,7 @@
                 <field name="bedrooms" string="Bedrooms"/>
                 <field name="living_area" string="Living Area"/>
                 <field name="facades" string="Facades"/>
-                <filter string="New or Offer Received" name="filter_available" domain="['|', ('status', '=', 'new'), ('status', '=', 'offer_receieved')]"/>
+                <filter string="Available" name="filter_available" domain="[('status', 'in', ['new', 'offer_receieved'])]"/>
                 <group expand="0" string="Group By">
                     <filter string="Postcode" name="post_code_grouping" context="{'group_by': 'postcode'}"/>
                 </group>

estate/views/estate_property_offer_actions.xml

@@ -7,7 +7,6 @@
             <list string="Offers">
                 <field name="price"/>
                 <field name="partner_id"/>
-                <field name="status"/>
             </list>
         </field>
     </record>
@@ -18,6 +17,8 @@
         <field name="arch" type="xml">
             <form string="Property Offer">
                 <sheet>
+                    <button name="action_accept_offer" class="btn-success" string="Accept" type="object"/>
+                    <button name="action_reject_offer" class="btn-danger" string="Reject" type="object"/>
                     <h1 class="mb32">
                         <field name="property_id"/>
                     </h1>
@@ -30,4 +31,20 @@
             </form>
         </field>
     </record>
+
+    <record id="estate_property_offer_list_view" model="ir.ui.view">
+        <field name="name">estate.property.offer.list_view</field>
+        <field name="model">estate.property.offer</field>
+        <field name="arch" type="xml">
+            <list string="Offers">
+                <field name="price" string="Offer Price"/>
+                <field name="partner_id"/>
+                <field name="deadline_date"/>
+                <field name="validity_days" string = "Validity"/>
+                <button name="action_accept_offer" type="object" icon="fa-check"/>
+                <button name="action_reject_offer" type="object" icon="fa-times"/>
+                <field name="status"/>
+            </list>
+        </field>
+    </record>
 </odoo>