Refactoring the reftests. #126
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Louciole
commented
Nov 13, 2025
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the reftests plugin from a monolithic single-file structure into a well-organized modular architecture, improving code maintainability and separation of concerns.
Key Changes:
- Extracts a 523-line monolithic
reftest.pyinto separate modules with clear responsibilities - Separates HTML/CSS/JavaScript from Python code into dedicated static asset files
- Introduces a
WebReportclass to encapsulate report generation logic - Creates utility functions for file fetching and message retrieval
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 14 comments.
Show a summary per file
| File | Description |
|---|---|
meta/plugins/reftest.py |
Deleted - replaced by modular structure in reftests/ directory |
meta/plugins/__init__.py |
Updated import to use new reftests module instead of old reftest |
meta/plugins/reftests/__init__.py |
New module initialization file |
meta/plugins/reftests/reftest.py |
Main reftest logic extracted and cleaned up from original file |
meta/plugins/reftests/utils.py |
Utility functions for file/message fetching extracted from main module |
meta/plugins/reftests/WebReport.py |
Web report generation logic encapsulated in dedicated class |
meta/plugins/reftests/report.js |
JavaScript code extracted from inline HTML string to separate file |
meta/plugins/reftests/report.css |
CSS styles extracted from inline HTML string to separate file |
Louciole
force-pushed
the
loha/reftests
branch
from
50ae2b2 to
88f8081
Compare
sleepy-monax
requested changes
Dec 8, 2025
Member
sleepy-monax
left a comment
sleepy-monax
left a comment
There was a problem hiding this comment.
This is going in a good direction
Comment on lines
+93
to
+99
| def shouldRunSkipped(self) -> bool: | ||
| """Check if skipped tests should be run.""" | ||
| return self.args.runSkipped | ||
|
|
||
| def shouldStopOnFailure(self) -> bool: | ||
| """Check if execution should stop on first failure.""" | ||
| return self.args.fast |
Member
There was a problem hiding this comment.
technically these could be marked as @Property, but fine as is
Member
Author
There was a problem hiding this comment.
we dont have a setter so it will just add verbosity without use
Louciole
force-pushed
the
loha/reftests
branch
from
b53f0ce to
3dadfef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.