[FIX] chart: prevent line chart value labels from clipping#8030
Open
[FIX] chart: prevent line chart value labels from clipping#8030
Conversation
Collaborator
rrahir
reviewed
Mar 3, 2026
src/components/figures/chart/chartJs/chartjs_show_values_plugin.ts
Outdated
Show resolved
Hide resolved
Before this commit: - Line chart value labels were clipped at chart edges. - First and last points could cut horizontally at left/right. - Top-most points could cut vertically at the top boundary. - Positioning relied on clamp, causing labels to stick to borders. After this commit: - Implement smart boundary-aware positioning for line labels. - Flip label below point if it cannot fit above. - Add horizontal edge detection and adjust textAlign dynamically. - Preserve existing bar chart behavior and layout settings. Task: 5993132
e59d4b1 to
2c868bd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description:
Current behavior before PR:
Desired behavior after PR is merged:
Task: 5993132
review checklist