[IMP] chart: add geo chart region selector#7958
Closed
Conversation
Collaborator
|
|
pro-odoo
force-pushed
the
master-add-geo-region-pro
branch
from
0bae966 to
e71747b
Compare
pro-odoo
force-pushed
the
master-add-geo-region-pro
branch
3 times, most recently
from
a201a45 to
5db5d7e
Compare
rrahir
reviewed
Mar 9, 2026
| export interface UpdateChartRegionCommand { | ||
| type: "UPDATE_CHART_REGION"; | ||
| chartId: UID; | ||
| region: string; |
Collaborator
There was a problem hiding this comment.
don't know if it's worth listing the exact regions that we support ?
Collaborator
Author
There was a problem hiding this comment.
I think no, the regions are given from the geoJsonService
| return []; | ||
| } | ||
| const allRegions = getAvailableRegions(); | ||
| return allRegions.filter((r) => r.id !== "usa"); |
Collaborator
There was a problem hiding this comment.
random thought: this looks a bit magic, I got the idea that you either group by countries or states but rejecting 'usa' looks weird out of context. In the future, we could think of categories (or trees) to filter out the kind of regions we can switch against.
Collaborator
Author
There was a problem hiding this comment.
Yes we could, but it's inside the geoJsonService so I wouldn't do something generic for that
pro-odoo
force-pushed
the
master-add-geo-region-pro
branch
from
5db5d7e to
37de771
Compare
rrahir
force-pushed
the
master-add-geo-region-pro
branch
from
37de771 to
efa154f
Compare
This commit adds a region selector to the geo charts in dashboard mode. Task: 5048552
rrahir
force-pushed
the
master-add-geo-region-pro
branch
from
efa154f to
3f4f044
Compare
Collaborator
|
robodoo r+ |
robodoo
pushed a commit
that referenced
this pull request
Mar 18, 2026
This commit adds a region selector to the geo charts in dashboard mode. closes #7958 Task: 5048552 Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit adds a region selector to the geo charts in dashboard mode.
Task-5048552