[IMP] topbar: number editor closes on right click#7944
Open
[IMP] topbar: number editor closes on right click#7944
Conversation
Collaborator
|
|
anhe-odoo
force-pushed
the
master-topbar-number_editor-context_menu-anhe
branch
2 times, most recently
from
ee2bb63 to
29f9719
Compare
hokolomopo
reviewed
Feb 17, 2026
anhe-odoo
force-pushed
the
master-topbar-number_editor-context_menu-anhe
branch
from
29f9719 to
7a120cc
Compare
hokolomopo
reviewed
Feb 24, 2026
Comment on lines
+43
to
+44
| useExternalListener(window, "click", this.closePicker); | ||
| useExternalListener(window, "contextmenu", this.closePicker, { capture: true }); |
Contributor
There was a problem hiding this comment.
rich clicking inside a color picker popover will close it now. That's probably now what we want ?
It should work fine for the components where we use isChildEvent in the external click handler. Not on the one where we were relying on a t-on-click.stop="" like the color picker.
Task Description Currently, if we right-click on the zoom editor, then on the font size editor and then somewhere else, we will end with both number editors open and a context menu from the last click. This commit aims to fix this behavior for all menu/popover/widget that listen to the click to closes menus/popover, extanding the listening to the right-click as well. Related Task Task: 5900107
anhe-odoo
force-pushed
the
master-topbar-number_editor-context_menu-anhe
branch
from
7a120cc to
59ed6f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task Description
Currently, if we right-click on the zoom editor, then on the font size editor and then somewhere else, we will end with both number editors open and a context menu from the last click. This commit aims to fix this behavior for all the menus/popovers/widgets that rely on the click detection to close their submenu/subpopover, extending this behavior to the right-click as well
Related Task