Skip to content

Conversation

@VincentSchippefilt
Copy link
Collaborator

During the split of the model, we changed the way the image generated for charts were handled. It worked well, except when exporting with Odoo because the zipping is done server side and the image definition was only available server side though URL.createObjectIrl()

This fix uses the standard fileReader to obtrain a true base64 image as text, like before

Task: 5253880

Description:

description of this task, what is implemented and why it is implemented that way.

Task: TASK_ID

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

During the split of the model, we changed the way the image generated for charts were handled.
It worked well, except when exporting with Odoo because the zipping is done server side and the image
definition was only available server side though URL.createObjectIrl()

This fix uses the standard fileReader to obtrain a true base64 image as text, like before

Task: 5253880
@robodoo
Copy link
Collaborator

robodoo commented Nov 10, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants