[FIX] TopbarMenu: specify isReadonlyAllowed
#7415
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
rrahir
force-pushed
the
saas-18.4-fix-menubar-visibility-mobile-rar
branch
from
cbb66ad to
53821ab
Compare
The logic that displays the top-level items of the topbarmenu is isolated from the `Menu` component logic. More specifically, it never checks if the item can be used in readonly and as such, we never took the time to define the key `isReadonlyAllowed` on those menu items. However `RibbonMenu` relies on the logic of `Menu` so in order to display the topbar menu items properly in mobile mode, we need the key `isReadonlyAllowed` to be defined. Task: 5245432
rrahir
force-pushed
the
saas-18.4-fix-menubar-visibility-mobile-rar
branch
from
53821ab to
a553d44
Compare
Collaborator
Author
|
@nseinlet if you want to follow the fix ^^ |
robodoo
pushed a commit
that referenced
this pull request
Nov 12, 2025
The logic that displays the top-level items of the topbarmenu is isolated from the `Menu` component logic. More specifically, it never checks if the item can be used in readonly and as such, we never took the time to define the key `isReadonlyAllowed` on those menu items. However `RibbonMenu` relies on the logic of `Menu` so in order to display the topbar menu items properly in mobile mode, we need the key `isReadonlyAllowed` to be defined. closes #7415 Task: 5245432 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
This was referenced Nov 12, 2025
rrahir
changed the title
isReadOnlyAllowedisReadonlyAllowed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic that displays the top-level items of the topbarmenu is isolated from the
Menucomponent logic. More specifically, it never checks if the item can be used in readonly and as such, we never took the time to define the keyisReadonlyAllowedon those menu items.However
RibbonMenurelies on the logic ofMenuso in order to display the topbar menu items properly in mobile mode, we need the keyisReadonlyAllowedto be defined.Task: 5245432
review checklist