Skip to content

Conversation

@rmbh-odoo
Copy link
Contributor

Description:

Before this commit:

  • splitReference removed single quotes from sheet names.

After this commit:

  • Applied getCanonicalSymbolName after splitReference to ensure sheet
    Names with spaces keep their quotes.

Task: 5244798

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Before this commit:
- 'splitReference' removed single quotes from sheet names.

After this commit:
- Applied 'getCanonicalSymbolName' after 'splitReference' to ensure sheet
  Names with spaces keep their quotes.

Task: 5244798
@robodoo
Copy link
Collaborator

robodoo commented Nov 6, 2025

Pull request status dashboard

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants