[FIX] GenericInput: skip focus manipulation #7383
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When providing the props `selectContentOnFocus`, we manipulate the default behaviour of the browser (mouseDown/mouseUp) to select the full content of the input. However, half of this manipulation (prevent mouseDown default) still occured even if the props `selectContentOnFocus` was set to false. Unfortunately, this cannot be properly tested as the update of the selected range on mouseDown does not seem programatically reproductible. Task: 5206980
Collaborator
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When providing the props
selectContentOnFocus, we manipulate the default behaviour of the browser (mouseDown/mouseUp) to select the full content of the input. However, half of this manipulation (prevent mouseDown default) still occured even if the propsselectContentOnFocuswas set to false.Unfortunately, this cannot be properly tested as the update of the selected range on mouseDown does not seem programatically reproductible.
Task: 5206980
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist