Master style text rotation flda #7376
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
|
fdamhaut
force-pushed
the
master-style-text-rotation-flda
branch
2 times, most recently
from
ed16251 to
0359de5
Compare
pro-odoo
reviewed
Nov 3, 2025
Comment on lines
45
to
49
| interface Expect { | ||
| toBeBetween(lower: number, upper: number): ExpectResult; | ||
| toBeSameColorAs(expected: string, tolerance?: number): ExpectResult; | ||
| toBeCloseTo(expected: number, closeDigit?: number): ExpectResult; | ||
| } |
Contributor
Author
There was a problem hiding this comment.
To allow its use inside toMatchObject(), the implementation is the same as the one described in jest doc
fdamhaut
force-pushed
the
master-style-text-rotation-flda
branch
2 times, most recently
from
94af3a6 to
bb3026e
Compare
Add rotation to the text style. Task-id: 5158912
LucasLefevre
force-pushed
the
master-style-text-rotation-flda
branch
from
bb3026e to
c870daf
Compare
Collaborator
LucasLefevre
left a comment
LucasLefevre
left a comment
There was a problem hiding this comment.
robodoo r+
(rebased to fix conflicts)
| fillColor?: Color; | ||
| textColor?: Color; | ||
| fontSize?: number; // in pt, not in px! | ||
| rotation?: number; // in rad, clockwise because y+ is down |
Collaborator
|
@fdamhaut @LucasLefevre because this PR has multiple commits, I need to know how to merge it:
|
Collaborator
|
robodoo rebase-ff |
Collaborator
|
Merge method set to rebase and fast-forward. |
robodoo
pushed a commit
that referenced
this pull request
Nov 14, 2025
Part-of: #7376 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
robodoo
pushed a commit
that referenced
this pull request
Nov 14, 2025
Add rotation to the text style. closes #7376 Task-id: 5158912 Signed-off-by: Lucas Lefèvre (lul) <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
description of this task, what is implemented and why it is implemented that way.
Task: 5158912
review checklist