[FIX] selection: prevent partial move of table rows with headers #6760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
hokolomopo
reviewed
Jul 15, 2025
src/plugins/ui_stateful/selection.ts
Outdated
Comment on lines
632
to
636
| const headerSelected = selectedRows.some( | ||
| (row) => row >= headerRowStart && row < headerRowEnd | ||
| ); | ||
|
|
||
| if (!headerSelected) { | ||
| return false; | ||
| } |
There was a problem hiding this comment.
probably not needed ? the loop below is enough no ?
There was a problem hiding this comment.
I kept the headerSelected check because we want to allow moving rows when the header is not selected.
The loop below only checks for completeness but doesn't distinguish whether the header is selected.
So this check is necessary to enforce: "Header selected but partial rows - not allowed."
Previously, it was possible to move only part of a table that includes header rows. This could result in broken table structure or orphaned headers. This commit prevents such partial row moves by disallowing the operation when the selected rows include header rows but not the full table range. Task: 4862731
dhrp-odoo
force-pushed
the
18.0-fix-table-move-columns-rows-dhrp
branch
from
b0e7f83 to
faa8eba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously, it was possible to move only part of a table that includes header rows.
This could result in broken table structure or orphaned headers.
This PR prevents such partial row moves by disallowing the operation when the selected rows include header rows but not the full table range.
Task: 4862731
review checklist