[FIX] Selection: selection follows the moved header #5443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Following the refactoring of the clipboard in #2857, we also isolated the flow of `MOVE_COLUMNS_ROWS` so it would not interfere with the clipboard. By doing so, we lost the capacity to select the moved header during the handling of the command. How to reproduce: - select row 2 - paint it red to identify it - move it to row 4 The selection is still on row 2 and not on row 4 as expected. Task: 4461901
rrahir
force-pushed
the
saas-17.2-fix-selection-move-header-rar
branch
from
c38f3df to
03fa8ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the refactoring of the clipboard in #2857, we also isolated the flow of
MOVE_COLUMNS_ROWSso it would not interfere with the clipboard. By doing so, we lost the capacity to select the moved header during the handling of the command.How to reproduce:
The selection is still on row 2 and not on row 4 as expected.
Task: 4461901
Description:
description of this task, what is implemented and why it is implemented that way.
Task: TASK_ID
review checklist