Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FW][FIX] borders: fix border on column/row deletion #5420

Open
wants to merge 1 commit into
base: 17.0
Choose a base branch
from

Conversation

fw-bot
Copy link
Collaborator

@fw-bot fw-bot commented Jan 8, 2025

  • Fix issue when deleting the first/last row/colum not deleting the exterior borders

  • Fix issue with wrong border movement when deleting row/col

  • Fix not removing internal border when deleting row/col

Task: 4089281

Description:

description of this task, what is implemented and why it is implemented that way.

Task: 4089281

review checklist

  • feature is organized in plugin, or UI components
  • support of duplicate sheet (deep copy)
  • in model/core: ranges are Range object, and can be adapted (adaptRanges)
  • in model/UI: ranges are strings (to show the user)
  • undo-able commands (uses this.history.update)
  • multiuser-able commands (has inverse commands and transformations where needed)
  • new/updated/removed commands are documented
  • exportable in excel
  • translations (_t("qmsdf %s", abc))
  • unit tested
  • clean commented code
  • track breaking changes
  • doc is rebuild (npm run doc)
  • status is correct in Odoo

Forward-Port-Of: #5300

- Fix issue when deleting the first/last row/colum not deleting
the exterior borders

- Fix issue with wrong border movement when deleting row/col

- Fix not removing internal border when deleting row/col

Task: 4089281
X-original-commit: 1f80887
@robodoo
Copy link
Collaborator

robodoo commented Jan 8, 2025

Pull request status dashboard

@fw-bot
Copy link
Collaborator Author

fw-bot commented Jan 8, 2025

@fdamhaut @rrahir cherrypicking of pull request #5300 failed.

stdout:

Auto-merging src/plugins/core/borders.ts
CONFLICT (modify/delete): tests/plugins/borders.test.ts deleted in 0277eb90d23ab73adfdb44dfcdc3d6ba68ff4f7c and modified in 0a0f18aef5d2fd0994b1aeacdf3f4f47ff1e5c8f.  Version 0a0f18aef5d2fd0994b1aeacdf3f4f47ff1e5c8f of tests/plugins/borders.test.ts left in tree.

Either perform the forward-port manually (and push to this branch, proceeding as usual) or close this PR (maybe?).

In the former case, you may want to edit this PR message as well.

⚠️ after resolving this conflict, you will need to merge it via @robodoo.

More info at https://github.com/odoo/odoo/wiki/Mergebot#forward-port

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants