[FIX] chart: labels should not be truncated in tooltip #5250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It make sense to truncate labels in the chart axis ticks & in the legend, but it should not be truncated in the tooltip. Otherwise, the user has no way to know the full label. Task: 4351338
|
|
|
requires a rebase :/ |
rrahir
reviewed
Dec 3, 2024
| @@ -440,3 +442,13 @@ export function getPieColors(colors: ColorGenerator, dataSetsValues: DatasetValu | |||
|
|
|||
| return pieColors; | |||
| } | |||
|
|
|||
| export function truncateLabel(label: string | undefined): string { | |||
There was a problem hiding this comment.
seems to me that it's more 'formatTickValue' that should move to chart_ui_common rather than the other way around as it's clearly 'UI' but that split in the helpers seems already shady atm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
It make sense to truncate labels in the chart axis ticks & in the legend, but it should not be truncated in the tooltip. Otherwise, the user has no way to know the full label.
Task: 4351338
review checklist