[FIX] export: Fix default style ignored at export

The default style values ignored at export were targetting the font color black (#000000) as the default value. However, the default value is the simple absence of value (or rather an empty string) as we should be able to differentiate it from a choice from the user to set the font color to black (e.g. when the cell is also receiving its style from a CF or a table). closes #5006 Task: 4178743 X-original-commit: 6cc0b14 Signed-off-by: Lucas Lefèvre (lul) <[email protected]> Signed-off-by: Rémi Rahir (rar) <[email protected]>
odoo · Sep 20, 2024 · 2289fc3 · 2289fc3
1 parent b57230f
commit 2289fc3
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/src/constants.ts b/src/constants.ts
@@ -160,7 +160,7 @@ export const DEFAULT_STYLE = {
   underline: false,
   fontSize: 10,
   fillColor: "",
-  textColor: "#000000",
+  textColor: "",
 } satisfies Required<Style>;
 
 export const DEFAULT_VERTICAL_ALIGN = DEFAULT_STYLE.verticalAlign;

diff --git a/tests/cells/style_plugin.test.ts b/tests/cells/style_plugin.test.ts
@@ -60,6 +60,14 @@ describe("styles", () => {
     expect(data.styles).toEqual({});
   });
 
+  test("textColor black(#000000) is exported as non default style", () => {
+    const model = new Model();
+    setStyle(model, "A1", { textColor: "#000000" });
+    const data = model.exportData();
+    expect(data.sheets[0].cells.A1?.style).toBe(1);
+    expect(data.styles).toEqual({ 1: { textColor: "#000000" } });
+  });
+
   test("only non default style values are exported", () => {
     const model = new Model();
     setStyle(model, "A1", {