Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IMP] sales: update customer addresses #3784

Closed
wants to merge 1 commit into from
Closed

[IMP] sales: update customer addresses #3784

wants to merge 1 commit into from

Conversation

meng-odoo
Copy link
Contributor

@meng-odoo meng-odoo commented Mar 9, 2023 •
edited
Loading

Updated this doc for Odoo 16, and rewrote it for clarity and brevity. Replaced images, and fixed image names and alt descriptions.
Closes task #3152071 and Issue #3693

@meng-odoo meng-odoo self-assigned this Mar 9, 2023
@robodoo
Copy link
Collaborator

robodoo commented Mar 9, 2023

Pull request status dashboard.

@C3POdoo C3POdoo requested a review from a team March 9, 2023 19:36
@meng-odoo
Copy link
Contributor Author

meng-odoo commented Mar 9, 2023 •
edited
Loading

Hi @StraubCreative this is ready for your review

@meng-odoo meng-odoo removed the request for review from a team March 9, 2023 19:36
@StraubCreative StraubCreative requested review from ksc-odoo and removed request for StraubCreative March 9, 2023 19:42
@StraubCreative
Copy link
Contributor

@ksc-odoo can you plz take a look at this doc? Any improvements y'all can tackle before it gets to me will improve likelihood of quick merge. TIA!

@meng-odoo meng-odoo linked an issue Mar 9, 2023 that may be closed by this pull request
Reference to the Customer Addresses setting not accurate if Accounting is installed #3693
Open
@meng-odoo meng-odoo mentioned this pull request Mar 9, 2023
Open
ksc-odoo
ksc-odoo reviewed Mar 9, 2023
View reviewed changes
Copy link
Contributor

@ksc-odoo ksc-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey @meng-odoo - I just did a quick review of your updates to this doc (per ZST's instructions). Just a few minor modifications to consider before passing it along to @StraubCreative for final review. Great job!!!

content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
@ksc-odoo
Copy link
Contributor

ksc-odoo commented Mar 9, 2023

@ksc-odoo can you plz take a look at this doc? Any improvements y'all can tackle before it gets to me will improve likelihood of quick merge. TIA!

@StraubCreative done deal. just a few small things to adjust and then it should be good to go. Let me know if there's anything else you need from me. Thanks!

@meng-odoo meng-odoo force-pushed the 16.0-sales-update-customer-addresses-meng branch from 4a61047 to 3a7dd62 Compare March 9, 2023 21:06
@meng-odoo
Copy link
Contributor Author

Thanks for the review @ksc-odoo! I've incorporated your suggestions on the latest commit.
@StraubCreative this is ready for you.

StraubCreative
StraubCreative requested changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @meng-odoo
Couple change requests here.
I like that the doc is simple and provides clear + linear instruction, however I think we can be more specific in some spots. See comments below.

content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
content/applications/sales/sales/send_quotations/different_addresses.rst Outdated Show resolved Hide resolved
@meng-odoo meng-odoo force-pushed the 16.0-sales-update-customer-addresses-meng branch from 3a7dd62 to 3d95097 Compare April 27, 2023 22:35
@meng-odoo
Copy link
Contributor Author

@StraubCreative whoops we never finalized this. I incorporated your changes in the latest commit. If you want to go ahead and merge, we can add this to Q1 deliverables :)

StraubCreative
StraubCreative approved these changes Apr 28, 2023
View reviewed changes
Copy link
Contributor

@StraubCreative StraubCreative left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Short and sweet 🙂

@robodoo r+

robodoo pushed a commit that referenced this pull request Apr 28, 2023
@meng-odoo
[IMP] sales: update customer addresses
0724908 
closes #3784

Signed-off-by: Zachary Straub (zst) <[email protected]>
@robodoo robodoo temporarily deployed to merge April 28, 2023 02:26 Inactive
@robodoo robodoo closed this Apr 28, 2023
This was referenced Apr 28, 2023
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksc-odoo ksc-odoo ksc-odoo left review comments

@StraubCreative StraubCreative StraubCreative approved these changes

Assignees

@meng-odoo meng-odoo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Reference to the Customer Addresses setting not accurate if Accounting is installed
4 participants
@meng-odoo @robodoo @StraubCreative @ksc-odoo