[IMP] Use latest nightly build by default#435
Conversation
amh-mw
left a comment
There was a problem hiding this comment.
I really like the intent of this pull request, especially since odoo/odoo#113967 still hasn't made it into the weekly and is breaking my builds. That said, I see a couple of problems:
- Given that
ODOO_RELEASEandODOO_SHAare updated every week by an internal build, accepting this commit would potentially break that (sed -i) process. - You can't safely curl sha1 hashes from an http (not https) source and then later use them to sha1sum validate the deb, as everything is untrustworthy at that point.
I'm probably still going to run with the spirit of this pull request, but as a shell script.
#!/bin/bash -e
ODOO_VERSION=15.0
ODOO_RELEASE=latest
ODOO_SHA=$(curl -sSL https://nightly.odoo.com/${ODOO_VERSION}/nightly/deb/Packages | grep -e "^SHA1:" | sed "s/SHA1: //")
docker build ./docker/odoo/$ODOO_VERSION --build-arg=ODOO_RELEASE=$ODOO_RELEASE --build-arg=ODOO_SHA=$ODOO_SHA|
Maybe I'm wrong. But isn't the docker triggered by the commit. So not changing the source would actually not trigger a docker build ? |
|
@ofahrni if this is still of interest can you update the PR to reflect 15, 16, and 17 along with changing to HTTPS urls. I use the Docker ADD in my personal builds as it supports HTTPS downloads. e.g. I just noticed that the checksum in https://nightly.odoo.com/17.0/nightly/deb/odoo_17.0.latest.dsc is incorrect and the correct one is in https://nightly.odoo.com/17.0/nightly/deb/Packages which is not awesome. |
Updated Dockerfile for versions 14.0, 15.0 and 16.0 to always use the "latest" nightly build available and automatically get the sha1 checksum for it.
Manually specifying the Odoo version and and sha1 checksum via build arguments is still possible.