-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IMP] Add option to customize wait-for-psql.py timeout #341
base: master
Are you sure you want to change the base?
Conversation
Allow users to pass a custom timeout value for the `wait-for-psql.py` script to the container via the `PSQL_TIMEOUT` environment variable. The timeout of 30 seconds still remains the default.
| cut -d " " -f3 \ | ||
| sed 's/["\n\r]//g' | ||
) | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes are just editor code formatting.
| cut -d " " -f3 \ | ||
| sed 's/["\n\r]//g' | ||
) | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again code formatting.
| cut -d " " -f3 \ | ||
| sed 's/["\n\r]//g' | ||
) | ||
fi |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code formatting as well.
@mamiu can you update this PR for 15, 16, 17 releases? |
@lathama Are you working for Odoo? I only wanna update this PR if I can be sure that someone's merging it. |
Allow users to pass a custom timeout value for the
wait-for-psql.py
script to the container via thePSQL_TIMEOUT
environment variable.The timeout of 30 seconds still remains the default.
Background
In our Kubernetes cluster the startup of the postgresql container takes sometimes a little longer than 30 seconds. This change offers users to adjust the timeout to a higher value to prevent the odoo container from getting stuck.