Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] Add option to customize wait-for-psql.py timeout #341

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[IMP] Add option to customize wait-for-psql.py timeout #341

wants to merge 1 commit into from

Conversation

mamiu
Copy link

@mamiu mamiu commented Nov 28, 2020

Allow users to pass a custom timeout value for the wait-for-psql.py script to the container via the PSQL_TIMEOUT environment variable.
The timeout of 30 seconds still remains the default.

Background

In our Kubernetes cluster the startup of the postgresql container takes sometimes a little longer than 30 seconds. This change offers users to adjust the timeout to a higher value to prevent the odoo container from getting stuck.

Allow users to pass a custom timeout value for the `wait-for-psql.py`
script to the container via the `PSQL_TIMEOUT` environment variable.
The timeout of 30 seconds still remains the default.
| cut -d " " -f3 \
| sed 's/["\n\r]//g'
)
fi
Copy link
Author

@mamiu mamiu Nov 28, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are just editor code formatting.

| cut -d " " -f3 \
| sed 's/["\n\r]//g'
)
fi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again code formatting.

| cut -d " " -f3 \
| sed 's/["\n\r]//g'
)
fi
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code formatting as well.

@mamiu mamiu changed the title [IMP] add option to customize wait-for-psql.py timeout [IMP] Add option to customize wait-for-psql.py timeout Nov 28, 2020
@lathama
Copy link

lathama commented Mar 31, 2024

@mamiu can you update this PR for 15, 16, 17 releases?

@mamiu
Copy link
Author

mamiu commented Apr 29, 2024

@lathama Are you working for Odoo? I only wanna update this PR if I can be sure that someone's merging it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants