Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] theme_*: POC website design in db #766

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[IMP] theme_*: POC website design in db #766

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion theme_avantgarde/static/src/scss/primary_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ $o-theme-font-configs: (
$o-website-values-palettes: (
(
'color-palettes-name': 'avantgarde-3',
'layout': 'full',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't hesitate to make extra PR that I can merge directly for things like these: defining layout = full in a theme is useless since this is a default (this is not wrong but I'd say it is best not to write it if useless).

If I can merge small stuff like these that are independent of your work directly, it will make the review easier later 👍


'font-size-base': 1rem,
'font': 'Syne',
Expand Down
1 change: 0 additions & 1 deletion theme_bewise/static/src/scss/primary_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,6 @@ $o-website-values-palettes: (
'font': 'Darker Grotesque',
'headings-font': 'Raleway',

'layout': 'full',
'header-template': 'default',
'menu-box-shadow': false,
'footer-template': 'headline',
Expand Down
1 change: 1 addition & 0 deletions theme_graphene/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
'data': [
'data/generate_primary_template.xml',
'data/ir_asset.xml',
'data/theme_website_design.xml',
'views/images_library.xml',
'views/customizations.xml',
'views/new_page_template.xml',
Expand Down
9 changes: 9 additions & 0 deletions theme_graphene/data/theme_website_design.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

<record id="theme_graphene.design" model="theme.website.design">
<field name="layout">'boxed'</field>
<field name="theme_id" ref="base.module_theme_graphene"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are actually filling the "theme.utils" many2one with a "ir.module.module" record, funny if it works ^^ Anyways, like I said in the other PR: you don't need that. You are in theme_graphene, you should never have to say "I am a theme_graphene record".

</record>

</odoo>
1 change: 0 additions & 1 deletion theme_graphene/static/src/scss/primary_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ $o-website-values-palettes: (
'headings-font': 'Assistant',

'btn-ripple': true,
'layout': 'boxed',
'header-template': 'sales_three',
'footer-template': 'centered',

Expand Down
1 change: 1 addition & 0 deletions theme_nano/__manifest__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
'data': [
'data/generate_primary_template.xml',
'data/ir_asset.xml',
'data/theme_website_design.xml',
'views/images_library.xml',

'views/snippets/s_banner.xml',
Expand Down
9 changes: 9 additions & 0 deletions theme_nano/data/theme_website_design.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
<?xml version="1.0" encoding="utf-8"?>
<odoo>

<record id="theme_nano.design" model="theme.website.design">
<field name="layout">'postcard'</field>
<field name="theme_id" ref="base.module_theme_nano"/>
</record>

</odoo>
1 change: 0 additions & 1 deletion theme_nano/static/src/scss/primary_variables.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,6 @@ $o-website-values-palettes: (
'buttons-font': 'Nunito',

// Body
'layout': 'postcard',
'btn-ripple': true,

// Footer
Expand Down