-
Notifications
You must be signed in to change notification settings - Fork 116
[IMP] account: add sent status column and filters on invoice list #4874
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 18.0-rd-accounting-onboarding-malb
Are you sure you want to change the base?
Conversation
|
This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged. |
malb-odoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still the commits problems + some impss
| domain=[('display_type', 'in', ('product', 'line_section', 'line_note'))], | ||
| ) | ||
| invoice_sent_status = fields.Selection( | ||
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], | |
| selection=[ | |
| ('sent', "Sent"), | |
| ('not_sent', "Not sent") | |
| ], |
| ) | ||
| invoice_sent_status = fields.Selection( | ||
| selection=[('sent', "Sent"), ('not_sent', "Not sent")], | ||
| compute='_compute_is_sent', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convention for the compute it should generally be like this, you take the name of the field as the name of compute (except if the compute is present on multiple field)
| compute='_compute_is_sent', | |
| compute='_compute_invoice_sent_status', |
| <filter name="invoice_sent_status" | ||
| string="Sent invoices" | ||
| domain="[('invoice_sent_status', '=', 'sent')]" | ||
| /> | ||
| <filter name="invoice_sent_status" | ||
| string="Not sent invoices" | ||
| domain="[('invoice_sent_status', '=', 'not_sent')]" | ||
| /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just look at the one below, the not_sent is already present so let's do the same but for sent, no need to add those extra 😄
To improve traceability for users, it is now necessary to easily see which invoices have been sent, especially with the rise of electronic invoicing. This commit adds the 'sent' status as an optional column in the invoice list view. It also introduces two new search filters: 'Sent Invoices' and 'Not Sent Invoices' to quickly track documents that need to be dispatched. task-5231314
64cc296 to
3cfd6a9
Compare
To improve traceability for users, it is now necessary to easily see which invoices have been sent, especially with the rise of electronic invoicing.
This PR adds the 'sent' status as an optional column in the invoice list view. It also introduces two new search filters: 'Sent Invoices' and 'Not Sent Invoices' to quickly track documents that need to be dispatched.
task-5231314
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr