Skip to content

Conversation

@jugurtha-gaci
Copy link

@jugurtha-gaci jugurtha-gaci commented Nov 6, 2025

This change introduces a dedicated search filter for monetary values on account.move.line (Journal Items).
Previously, searching directly by an exact or minimum amount was not possible. This PR allows users to filter using syntax like 'balance >= 1000'.

To ensure comprehensive results, the filter checks the entered value against both the 'credit' and 'debit' fields simultaneously, guaranteeing that transactions matching the amount are returned regardless of whether they are recorded as a debit or a credit.

task-5231308


I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@robodoo
Copy link

robodoo commented Nov 6, 2025

This PR targets the un-managed branch odoo-dev/odoo:18.0-rd-accounting-onboarding-malb, it needs to be retargeted before it can be merged.

Copy link

@malb-odoo malb-odoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Remove the other commit that is useless, and still you changed the PR description but not the commit one, we need to do both 😄

<field name="name" string="Journal Item" filter_domain="[
'|', '|', '|',
('name', 'ilike', self), ('ref', 'ilike', self), ('account_id', 'ilike', self), ('partner_id', 'ilike', self)]"/>
<field name="balance" filter_domain="[('balance', '&gt;=', self)]" />

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The balance could be negative and you want to check that also 👀 So i would check on the field balance entirely or why not using the debit and the credit with a or 😎

@jugurtha-gaci jugurtha-gaci force-pushed the 18.0-rd-accounting-onboarding-search-by-amount-jugac branch 2 times, most recently from 40e765a to ed5d81d Compare November 10, 2025 09:20
@jugurtha-gaci jugurtha-gaci changed the title [IMP] account: allow the search of a journal item by amount [IMP] account: search of a journal item by amount Nov 10, 2025
This change introduces a dedicated search filter for monetary values on account.move.line (Journal Items).
Previously, searching directly by an exact or minimum amount was not possible. This commit allows users to filter using syntax like 'balance >= 1000'.
To ensure comprehensive results, the filter checks the entered value against both the 'credit' and 'debit' fields simultaneously, guaranteeing that transactions matching the amount are returned regardless of whether they are recorded as a debit or a credit.
task-5231308
@jugurtha-gaci jugurtha-gaci force-pushed the 18.0-rd-accounting-onboarding-search-by-amount-jugac branch from ed5d81d to 525d9cf Compare November 10, 2025 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants