Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some long awaited fixes #152

Merged
merged 10 commits into from
May 29, 2024
Merged

some long awaited fixes #152

merged 10 commits into from
May 29, 2024

Conversation

albertotirla
Copy link
Member

ever since my previous pull request got closed prematurely, there have been some bugs, which I'm fixing here. A non-exhaustive list of bugs and unexpected behaviours is as follows:

  • logging: program no longer outputs to two different streams, though the journald logger is a bit weird, as it doesn't seemn to send log events with the custom attached fields
  • configuration: values defined in the system configuration are no longer ignored and the values written to disk in case of a missing initial config.toml file in the user's home directory now includes those too

albertotirla and others added 10 commits May 26, 2024 20:18
…r errors for other reasons than not found, since we give the values provided in the configuration anyway
…nd the logging method described in the configuration file
…t specified and make the toml writer to write all the layers before the user one in the configuration it writes to disk in case of missing configuration
…ributes when their output in the logs would be redundant
@albertotirla albertotirla merged commit a31331e into main May 29, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant