forked from googleapis/python-spanner
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
feat(x-goog-spanner-request-id): introduce AtomicCounter
This change introduces AtomicCounter, a concurrency/thread-safe counter do deal with the multi-threaded nature of variables. It permits operations: * atomic_counter += 1 * value = atomic_counter + 1 * atomic_counter.value that'll be paramount to bringing in the logic for x-goog-spanner-request-id in much reduced changelists. Updates googleapis#1261 Carved out from PR googleapis#1264
- Loading branch information
Showing
3 changed files
with
166 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# Copyright 2024 Google LLC All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import os | ||
import threading | ||
|
||
REQ_ID_VERSION = 1 # The version of the x-goog-spanner-request-id spec. | ||
REQ_ID_HEADER_KEY = "x-goog-spanner-request-id" | ||
|
||
|
||
def generate_rand_uint64(): | ||
b = os.urandom(8) | ||
return ( | ||
b[7] & 0xFF | ||
| (b[6] & 0xFF) << 8 | ||
| (b[5] & 0xFF) << 16 | ||
| (b[4] & 0xFF) << 24 | ||
| (b[3] & 0xFF) << 32 | ||
| (b[2] & 0xFF) << 36 | ||
| (b[1] & 0xFF) << 48 | ||
| (b[0] & 0xFF) << 56 | ||
) | ||
|
||
|
||
REQ_RAND_PROCESS_ID = generate_rand_uint64() | ||
|
||
|
||
def with_request_id(client_id, channel_id, nth_request, attempt, other_metadata=[]): | ||
req_id = f"{REQ_ID_VERSION}.{REQ_RAND_PROCESS_ID}.{client_id}.{channel_id}.{nth_request}.{attempt}" | ||
other_metadata.append((REQ_ID_HEADER_KEY, req_id)) | ||
return other_metadata |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,81 @@ | ||
# Copyright 2024 Google LLC All rights reserved. | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
# You may obtain a copy of the License at | ||
# | ||
# http://www.apache.org/licenses/LICENSE-2.0 | ||
# | ||
# Unless required by applicable law or agreed to in writing, software | ||
# distributed under the License is distributed on an "AS IS" BASIS, | ||
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
# See the License for the specific language governing permissions and | ||
# limitations under the License. | ||
|
||
import time | ||
import random | ||
import threading | ||
import unittest | ||
from google.cloud.spanner_v1._helpers import AtomicCounter | ||
|
||
|
||
class TestAtomicCounter(unittest.TestCase): | ||
def test_initialization(self): | ||
ac_default = AtomicCounter() | ||
assert ac_default.value == 0 | ||
|
||
ac_1 = AtomicCounter(1) | ||
assert ac_1.value == 1 | ||
|
||
ac_negative_1 = AtomicCounter(-1) | ||
assert ac_negative_1.value == -1 | ||
|
||
def test_increment(self): | ||
ac = AtomicCounter() | ||
result_default = ac.increment() | ||
assert result_default == 1 | ||
assert ac.value == 1 | ||
|
||
result_with_value = ac.increment(2) | ||
assert result_with_value == 3 | ||
assert ac.value == 3 | ||
result_plus_100 = ac.increment(100) | ||
assert result_plus_100 == 103 | ||
|
||
def test_plus_call(self): | ||
ac = AtomicCounter() | ||
ac += 1 | ||
assert ac.value == 1 | ||
|
||
n = ac + 2 | ||
assert n == 3 | ||
assert ac.value == 1 | ||
|
||
n = 200 + ac | ||
assert n == 201 | ||
assert ac.value == 1 | ||
|
||
def test_multiple_threads_incrementing(self): | ||
ac = AtomicCounter() | ||
n = 200 | ||
m = 10 | ||
|
||
def do_work(): | ||
for i in range(m): | ||
ac.increment() | ||
|
||
threads = [] | ||
for i in range(n): | ||
th = threading.Thread(target=do_work) | ||
threads.append(th) | ||
th.start() | ||
|
||
time.sleep(0.3) | ||
|
||
random.shuffle(threads) | ||
for th in threads: | ||
th.join() | ||
assert th.is_alive() == False | ||
|
||
# Finally the result should be n*m | ||
assert ac.value == n * m |