Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement optional manifest update #177

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

DarkFighterLuke
Copy link

This PR introduces a new optional parameter to update the manifest.json with the plugin release just built.
The default behavior is to not update the manifest, just like now.

This PR addresses #176

Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@oddstr13
Copy link
Owner

I'll get around to reviewing (and testing) this eventually, but for now, you should be able to just use your own fork.

Alternatively, there is nothing preventing you from installing jprm and running these commands directly in your plugin's CI.

Copy link
Owner

@oddstr13 oddstr13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After having taken a closer look at your implementation here, I've decided that this isn't generic enough, as it expects a very specific repository setup.

I'll eventually get around to implementing a version that satisfies my desired requirements, but it isn't high on my priority list at the moment.

For now, I suggest that people either pip install JPRM in a script action and implement the required logic there, or use your branch directly (pin to commit hash).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants