Added /fly command and adjusted sleep requirement. by junerhobart · Pull Request #335 · oddlama/vane

junerhobart · 2025-10-14T12:24:49Z

Changes

Added /fly command Players can now fly within their own region or any region where they have build permissions.
Adjusted bedtime percentage Reduced required sleep percentage from 50% to 20%.

### Changes - Added `/fly` command Players can now fly within their own region or any region where they have build permissions. - Adjusted bedtime percentage Reduced required sleep percentage from **50%** to **20%**.

Updated the webpage to reflect my previous changes being /fly in regions and 50% sleep requirement to 20%

junerhobart · 2025-10-14T12:51:32Z

If you have any questions please contact me at "@junologist" on discord

Sylfare · 2025-10-14T19:28:34Z

vane-bedtime/src/main/java/org/oddlama/vane/bedtime/Bedtime.java

    // Configuration
    @ConfigDouble(
-        def = 0.5,
+        def = 0.2,


I'm not sure if changing this default value is a good idea.

Yes, please remove that change

Sylfare · 2025-10-14T19:31:17Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+    private static final long FALL_DAMAGE_PROTECTION_MS = 15000; // 15 seconds
+
+    // Track players who manually disabled flight via /fly (opt-out of auto-fly)
+    private java.util.HashSet<UUID> manual_fly_opt_out = new java.util.HashSet<>();


You can directly import HashSet

Sylfare · 2025-10-14T19:35:20Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+        if (event.getFrom().getBlockX() == event.getTo().getBlockX() &&
+            event.getFrom().getBlockY() == event.getTo().getBlockY() &&
+            event.getFrom().getBlockZ() == event.getTo().getBlockZ()) {


idk if event.getFrom.equals(event.getTo()) works here?

Sylfare · 2025-10-14T19:47:34Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+
+    // Track players who are protected from fall damage after leaving a region
+    private Map<UUID, Long> fall_damage_protected = new HashMap<>();
+    private static final long FALL_DAMAGE_PROTECTION_MS = 15000; // 15 seconds


This should be configurable

I will make sure to add that

Sylfare · 2025-10-14T19:51:23Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Fly.java

+        final var region = get_module().region_at(player.getLocation());
+
+        if (region == null) {
+            player.sendMessage("§cYou must be inside a region to use this command.");


This hard-coded message should be translatable

Forgot about that that might take a while for all of them

Sylfare · 2025-10-14T19:52:03Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Fly.java

+            get_module().fly_manager.set_manual_opt_out(player.getUniqueId(), true);
+            // Stop visualizing the region
+            get_module().stop_visualizing_region(player.getUniqueId());
+            player.sendMessage("§aFlight disabled.");


This hard-coded message should be translatable

Sylfare · 2025-10-14T19:52:11Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Fly.java

+            get_module().fly_manager.set_manual_opt_out(player.getUniqueId(), false);
+            // Start visualizing the region
+            get_module().start_visualizing_region(player.getUniqueId(), region);
+            player.sendMessage("§aFlight enabled.");


This hard-coded message should be translatable

Sylfare · 2025-10-14T19:52:38Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Region.java

+
+        if (get_module().is_visualizing_region(player_id)) {
+            get_module().stop_visualizing_region(player_id);
+            player.sendMessage("§cRegion visualization disabled.");


This hard-coded message should be translatable

Sylfare · 2025-10-14T19:52:43Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Region.java

+        } else {
+            final var region = get_module().region_at(player.getLocation());
+            if (region == null) {
+                player.sendMessage("§cYou must be inside a region to visualize it.");


This hard-coded message should be translatable

Sylfare · 2025-10-14T19:52:50Z

vane-regions/src/main/java/org/oddlama/vane/regions/commands/Region.java

+            }
+
+            get_module().start_visualizing_region(player_id, region);
+            player.sendMessage("§aVisualizing region boundaries. Use §b/region visualize§a again to disable.");


This hard-coded message should be translatable

Sylfare · 2025-10-14T19:54:34Z

TODO

This file seems quite old but idk if we should delete it

It definitely is old. But you are right, if we decide to delete it, it probably shouldn't be in this PR. So let's keep it for now.

Sylfare · 2025-10-14T19:57:04Z

docs/index.html

+<li>Upon entering a region where you have permissions, flight is automatically enabled—just double-jump to start flying</li>
+<li>Use <code>/fly</code> to manually toggle flight on/off with visual feedback</li>
+<li>Particle visualization shows region boundaries while flying, automatically updating when moving between regions</li>
+<li>Fall damage protection is provided when exiting a region while airborne</li>
+<li>Flight automatically disables when leaving the region or entering an area without permissions</li>


These sentences does not have points at the end.

Sylfare · 2025-10-14T19:58:37Z

docs/index.html

 <blockquote>
 <p>Why can't I build anything?</p>
-</blockquote>
+"</blockquote>


trailing quote

Sylfare · 2025-10-14T20:08:07Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+            final var region = get_module().all_regions().stream()
+                .filter(r -> r.id().equals(region_id))
+                .findFirst()
+                .orElse(null);
+
+            if (region != null) {
+                // Mark as actively flying
+                flying_players.put(player_id, region_id);
+                // Start visualizing the region
+                get_module().start_visualizing_region(player_id, region);
+            }


ifPresent could be used here

get_module().all_regions().stream() .filter(r -> r.id().equals(region_id)) .findFirst() .ifPresent(region -> { // Mark as actively flying flying_players.put(player_id, region_id); // Start visualizing the region get_module().start_visualizing_region(player_id, region); });

oddlama · 2025-10-18T08:18:56Z

TODO

It definitely is old. But you are right, if we decide to delete it, it probably shouldn't be in this PR. So let's keep it for now.

docs/index.html

documentation/content/vane-admin/graylist.md

oddlama · 2025-10-18T08:29:56Z

vane-bedtime/src/main/java/org/oddlama/vane/bedtime/Bedtime.java

    // Configuration
    @ConfigDouble(
-        def = 0.5,
+        def = 0.2,


Yes, please remove that change

vane-core/build.gradle.kts

vane-regions/src/main/java/org/oddlama/vane/regions/Regions.java

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

- revert sleep threshold default back to 0.5 - restore org.json relocation in build.gradle.kts - import HashSet directly instead of fully-qualified - fall damage protection now always applies, not just when high up - simplify fall damage check using remove() - use StringUtils.removeStart instead of substring - drop /vane reload from graylist docs, just restart - fix missing leading slash on perm add commands in graylist - move flight in regions docs to regions.md source file

Sylfare

Other lang files are not updated yet

Sylfare · 2026-02-23T17:05:24Z

documentation/content/vane-admin/graylist.md


+### Quick start
+
+- Enable in `vane-admin` config: set `world_protection.enabled: true`, then restart the server.


Does /vane reload works here, or do you really have to restart the server?

Sylfare · 2026-02-23T17:08:37Z

docs/index.html

 <div id="body-feature-vane-bedtime--night_to_day" class="hidden">
 	<div class="p-5 border border-b-0 border-gray-200 dark:border-gray-700 dark:bg-gray-900">
-		<div class="prose prose-slate prose-img:rounded-xl prose-img:w-1/3 prose-img:sm:m-4 prose-img:w-full prose-img:sm:w-1/2 prose-img:lg:w-2/5 prose-img:min-w-32 prose-img:max-w-full prose-img:float-right prose-img:clear-right prose-h1:clear-right prose-h2:clear-right prose-img:float-right dark:prose-invert max-w-none"><p>Once at least 50% of all players in the world are asleep, the night is skipped with a smooth transition to the next day.</p></div>
+		<div class="prose prose-slate prose-img:rounded-xl prose-img:w-1/3 prose-img:sm:m-4 prose-img:w-full prose-img:sm:w-1/2 prose-img:lg:w-2/5 prose-img:min-w-32 prose-img:max-w-full prose-img:float-right prose-img:clear-right prose-h1:clear-right prose-h2:clear-right prose-img:float-right dark:prose-invert max-w-none"><p>Once at least 20% of all players in the world are asleep, the night is skipped with a smooth transition to the next day.</p></div>


The limit is back to 50%, you should regenerate the docs

Sylfare · 2026-02-23T17:14:18Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+        if (region == null) {
+            return false;
+        }


I have a doubt about this: does it allows players who can fly with some other ways, like Essentials' /fly command?

Sylfare · 2026-02-23T17:18:02Z

vane-regions/src/main/java/org/oddlama/vane/regions/RegionFlyManager.java

+        if (!(event.getEntity() instanceof Player)) {
+            return;
+        }
+
+        // Only handle fall damage
+        if (event.getCause() != EntityDamageEvent.DamageCause.FALL) {
+            return;
+        }
+
+        final var player = (Player) event.getEntity();


You can avoid the cast on L211 by adding the variable name after instanceof

if (!(event.getEntity() instanceof Player player)) { return; } // Only handle fall damage if (event.getCause() != EntityDamageEvent.DamageCause.FALL) { return; } final var player_id = player.getUniqueId();

Sylfare · 2026-02-23T17:23:02Z

vane-trifles/build.gradle.kts

-	shadowJar {
-		configurations = listOf()
-		relocate("org.json", "org.oddlama.vane.external.json")
-	}


I don't know enough about shadowing, but I'm not sure this is a good idea to remove it

- fix bedtime docs still showing 20% instead of 50% - restore org.json relocation in vane-trifles - use instanceof pattern matching in fall damage handler - don't manage flight for players who already have it from elsewhere (Essentials etc) - add fly/visualize lang keys to all non-English lang files, bump to version 4

June Hobart added 2 commits October 14, 2025 14:21

Added /fly command and adjusted sleep requirement.

d49a543

### Changes - Added `/fly` command Players can now fly within their own region or any region where they have build permissions. - Adjusted bedtime percentage Reduced required sleep percentage from **50%** to **20%**.

Updated the webpage to reflect my previous changes

0213f1d

Updated the webpage to reflect my previous changes being /fly in regions and 50% sleep requirement to 20%

June Hobart added 2 commits October 14, 2025 16:21

Added clearer documentation for graylist

afac110

Merge branch 'oddlama:main' into main

4f0861e

Sylfare reviewed Oct 14, 2025

View reviewed changes

June Hobart added 3 commits October 15, 2025 18:05

Fixed translation issue

e4ee5ed

Merge branch 'main' of https://github.com/junerhobart/vane

e46fcc7

Fixed a mountian of bugs

58e577c

oddlama requested changes Oct 18, 2025

View reviewed changes

junerhobart and others added 2 commits February 23, 2026 16:37

Merge branch 'oddlama:main' into main

793cfe2

junerhobart force-pushed the main branch from e68efec to ae9d0ff Compare February 23, 2026 16:55

Sylfare reviewed Feb 23, 2026

View reviewed changes

junerhobart force-pushed the main branch from 9ae25d2 to ec43be8 Compare February 23, 2026 18:00


		### Quick start

		- Enable in `vane-admin` config: set `world_protection.enabled: true`, then restart the server.

Uh oh!

Conversation

junerhobart commented Oct 14, 2025

Changes

Uh oh!

junerhobart commented Oct 14, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Sylfare left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants