Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs #260

Merged
merged 3 commits into from
Jul 10, 2024
Merged

Update docs #260

merged 3 commits into from
Jul 10, 2024

Conversation

Sylfare
Copy link
Contributor

@Sylfare Sylfare commented Jul 9, 2024

  • Add missing Lightning enchantment
  • Update smithing table GUI
  • Remove some swearing from descriptions, it's a personal choice but it feels more "professional"
  • Added package.json to facilitate docs updating

@oddlama
Copy link
Owner

oddlama commented Jul 9, 2024

Thanks you! I should have updated this a long time ago, glad to see it taken care of ❤️

* Remove some swearing from descriptions, it's a personal choice but it feels more "professional"

I must admit that I liked them occasionally, since it can convey that the project doesn't take itself too seriously. Because generally I don't believe a gaming project has to come across as strictly professional. But I can see why someone might not like this particular swear word.

Maybe we could have swapped it with something more mundane (darn, frick, ...) to still convey the joking atmosphere if you know what I mean. But quite honestly I don't have any strong opinion on this. If you think it is better without, then it's fine by me too. Definitely let me know your opinion is on this!

@Sylfare
Copy link
Contributor Author

Sylfare commented Jul 10, 2024

Yes, jokes are cool. But I think "fuck" is maybe a bit too strong.

@oddlama oddlama merged commit 29788a0 into oddlama:develop Jul 10, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants