A non-ideal (and probably erroneous) approach to retrying on failed pushes #292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shonfeder
force-pushed
the
211/retry-on-flakey-errors
branch
from
4c3e91f to
c780ffd
Compare
shonfeder
force-pushed
the
211/retry-on-flakey-errors
branch
from
c780ffd to
57b9427
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sharing this draft to help inform discussion on approaches to #211
I think this shows that it is possible to add retry logic to docker pushes without either reimplementing the
push_manifestcurrent or making changes to ocurrent. However, I think it also shows that this approach isn't ideal.I don't think we'll consider this for merging, but in case we do: I suspect the caching logic of
Wait_currentis wrong, and would want to validate that.