Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor tests #42

Merged
merged 7 commits into from
Jun 3, 2024
Merged

Refactor tests #42

merged 7 commits into from
Jun 3, 2024

Conversation

CamaradeRoman
Copy link
Collaborator

@CamaradeRoman CamaradeRoman commented May 31, 2024

Also:

  • add issueKey parameter validation
  • add files sorting in CommitWithFiles

@CamaradeRoman CamaradeRoman added the enhancement New feature or request label May 31, 2024
@CamaradeRoman CamaradeRoman self-assigned this May 31, 2024
Copy link

gitguardian bot commented May 31, 2024

⚠️ GitGuardian has uncovered 2 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
11399842 Triggered Generic High Entropy Secret 38bdb9a ft/docker/gitea/application-gitea.yml View secret
11399842 Triggered Generic High Entropy Secret 38bdb9a ft/src/ft/kotlin/org/octopusden/octopus/vcsfacade/VcsFacadeFunctionalTestGitea.kt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@CamaradeRoman CamaradeRoman merged commit a1aa45a into main Jun 3, 2024
3 checks passed
@CamaradeRoman CamaradeRoman deleted the refactor-tests branch June 3, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants