Support subprojects in export dependencies to TeamCity #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
fishinitself
commented
Jun 20, 2024
fishinitself
commented
- Capability to automatically export dependencies to TeamCity for each Gradle subproject individually.
- Capability to explicitly declare dependencies through the plugin DSL and export them to TeamCity for each Gradle subproject individually.
pgorbachev
reviewed
Jun 21, 2024
...ces/teamcity-dependencies-registration/sub-projects/gradle/wrapper/gradle-wrapper.properties
Show resolved
Hide resolved
pgorbachev
reviewed
Jun 21, 2024
ft/src/test/resources/teamcity-dependencies-registration/template-all-deps-root_prj.properties
Outdated
Show resolved
Hide resolved
pgorbachev
reviewed
Jun 21, 2024
ft/src/test/resources/teamcity-dependencies-registration/template-all-deps-root_prj.properties
Outdated
Show resolved
Hide resolved
pgorbachev
reviewed
Jun 22, 2024
ft/src/test/resources/teamcity-dependencies-registration/template-all-deps-root_prj.properties
Show resolved
Hide resolved
| -PbuildVersion=1.0-SNAPSHOT \ | ||
| -Pversion=1.0-SNAPSHOT \ | ||
| -Dorg.gradle.internal.publish.checksums.insecure=true \ | ||
| -Plicense-management.version=0.1.89 \ |
ft/src/test/resources/teamcity-dependencies-registration/template-all-deps-root_prj.properties
Show resolved
Hide resolved
| -Dorg.gradle.internal.publish.checksums.insecure=true \ | ||
| -Plicense-management.version=0.1.89 \ | ||
| -Plicense-maven-plugin.version=1.14.230 \ | ||
| -Plicense.skip=false \ |
| @@ -0,0 +1,19 @@ | |||
| command-and-arguments=-Poctopus-release-management.version=__RELEASE_MANAGEMENT_VERSION__ \ | |||
There was a problem hiding this comment.
Давай уберем legacy как в прошлом примере
| @@ -0,0 +1,18 @@ | |||
| command-and-arguments=-Poctopus-release-management.version=__RELEASE_MANAGEMENT_VERSION__ \ | |||
| -PbuildVersion=1.0-SNAPSHOT \ | |||
| @@ -0,0 +1,17 @@ | |||
| command-and-arguments=-Poctopus-release-management.version=__RELEASE_MANAGEMENT_VERSION__ \ | |||
This reverts commit b59279b.
pgorbachev
reviewed
Jun 22, 2024
| Arguments.of("multi-module-with-root-publish-4.10.3", listOf("multi-module-with-root-publish-4.10.3", "module-5")), | ||
| Arguments.of("legacy-staging-plugin", listOf("deployer-dsl-core", "deployer-dsl-file")) | ||
| Arguments.of("multi-module-with-root-publish-4.10.3", listOf("multi-module-with-root-publish-4.10.3", "module-5")) | ||
| // Arguments.of("legacy-staging-plugin", listOf("deployer-dsl-core", "deployer-dsl-file")) |
There was a problem hiding this comment.
gradle-staging-plugin не используется, его можно удалить (м.б. отдельным PR?)
Но возможно в этом тесте есть сценарий, который не покрывается другими тестами? т.е. просто заменив gradle-staging-plugin -> rm-gradle-plugin
There was a problem hiding this comment.
Т.е. тест предлагаю не выключать, а упростить\заменить на проверку того, что конструкции вида escrowBuild, nexusStaging по прежнему поддержаны. (других тестов на это я не вижу)
pgorbachev
approved these changes
Jun 26, 2024
CamaradeRoman
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.