Synchronize getEmployeeAvailableEarlier between the server and client #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ozonophore
force-pushed
the
sync_method
branch
from
b3fc409
to
cd32543
Compare
ozonophore
requested review from
pgorbachev,
fishinitself,
aryabokon,
CamaradeRoman and
gh-octopusden
aryabokon
requested changes
Nov 1, 2023
| @@ -36,7 +36,7 @@ interface EmployeeServiceClient { | |||
|
|
|||
| @Throws(NotFoundException::class) | |||
| @RequestLine("GET employees/available-earlier?employees={employees}", collectionFormat = CollectionFormat.CSV) | |||
| fun getEmployeeAvailableEarlier(@Param("employees") @QueryMap employees: List<String>): Employee | |||
| fun getEmployeeAvailableEarlier(@Param("employees") employees: Set<String>): Employee | |||
There was a problem hiding this comment.
контрак поменяется в отношениях клиент/сервер: Тут не зря collectionFormat.CSV еще проставлен (нельзя просто взять и убрать @QueryMap)
| @@ -45,7 +45,7 @@ class ClassicEmployeeServiceClient( | |||
|
|
|||
| override fun getEmployee(employee: String): Employee = client.getEmployee(employee) | |||
|
|
|||
| override fun getEmployeeAvailableEarlier(employees: List<String>): Employee = | |||
| override fun getEmployeeAvailableEarlier(employees: Set<String>): Employee = | |||
There was a problem hiding this comment.
А ради чего мы коллекции меняем?
There was a problem hiding this comment.
На сервере Set. Должно быть синхронно
MrSoftwareEngineer
approved these changes
Nov 2, 2023
aryabokon
approved these changes
Nov 2, 2023
aryabokon
requested review from
MrSoftwareEngineer
and removed request for
MrSoftwareEngineer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#43