Set up CodeCov, fix formatting and clippy warnings on stable Rust (#19)

* add codecov token

* fix tendermint dep

* add token to repo

* fix fmt

* Fix clippy warning

* Switch back CI to stable Rust

* Adapt rustfmt config for stable

Co-authored-by: Romain Ruetschi <[email protected]>

.github/workflows/rust.yml

@@ -15,7 +15,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: stable
           override: true
       - uses: actions-rs/cargo@v1
         with:
@@ -28,7 +28,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: stable
           components: clippy
           override: true
       - uses: actions-rs/clippy-check@v1
@@ -42,7 +42,7 @@ jobs:
       - uses: actions/checkout@v2
       - uses: actions-rs/toolchain@v1
         with:
-          toolchain: nightly
+          toolchain: stable
           override: true
       - uses: actions-rs/cargo@v1
         with:

.rustfmt.toml

@@ -1,12 +1,9 @@
-unstable_features = true
-
-# comments
-comment_width = 100
-wrap_comments = true
-
-# imports
+max_width = 100
 reorder_imports = true
 
-# strings
-format_strings = false
-max_width = 100
+# nightly only
+
+# unstable_features = true
+# format_strings = false
+# comment_width = 100
+# wrap_comments = true

modules/Cargo.toml

@@ -10,7 +10,7 @@ authors = [
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 
 [dependencies]
-tendermint = { path = "../../tendermint-rs/tendermint" }
+tendermint = { git = "https://github.com/interchainio/tendermint-rs.git" }
 anomaly = "0.2.0"
 thiserror = "1.0.11"
 serde_derive = "1.0.104"

modules/src/ics02_client/client_type.rs

@@ -9,7 +9,7 @@ pub enum ClientType {
 
 impl ClientType {
     /// Yields the identifier of this client type as a string
-    pub fn as_string(&self) -> &'static str {
+    pub fn as_string(self) -> &'static str {
         match self {
             Self::Tendermint => "tendermint",
         }

modules/src/ics02_client/msgs.rs

@@ -3,7 +3,8 @@ use super::header::Header;
 use super::state::ConsensusState;
 use crate::ics24_host::client::ClientId;
 
-// FIXME: Remove Header associated type and use Box<dyn tendermint::lite::Header> instead of Self::Header?
+// FIXME: Remove Header associated type and use Box<dyn tendermint::lite::Header> instead of
+// Self::Header?
 
 pub trait Msg {
     type ValidationError: std::error::Error;

modules/src/ics24_host/validate.rs

@@ -12,7 +12,8 @@ const PATH_SEPARATOR: char = '/';
 
 /// Default validator function for identifiers.
 ///
-/// A valid identifier only contain lowercase alphabetic characters, and be of a given min and max length.
+/// A valid identifier only contain lowercase alphabetic characters, and be of a given min and max
+/// length.
 pub fn validate_identifier(id: &str, min: usize, max: usize) -> Result<(), ValidationError> {
     assert!(max >= min);