chore: add serverless integration tests #931
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is no need to always ping me. I get notifications on all JS Octokit repos, and I also get notifications for Probot repos I have access to |
|
It's not clear to me what this is covering that we've not already got covered - we've already required 100% code coverage, and this doesn't seem to be testing against every popular serverless runtime environment so I'm not sure how this change would allow us to claim we're serverless compatible anymore than we can now (which I think is fine for us to do without these tests), and not sure if it justifies the maintenance burden of having all the extra tests... |
wolfy1339
added
the
Type: Maintenance
|
Ok, Cabal. ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #930
Adds tests for serverless and ensures that we can claim that we are supporting serverless.
@wolfy1339
Before the change?
After the change?
Pull request checklist
Does this introduce a breaking change?
Please see our docs on breaking changes to help!