Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove usage of node-fetch #865

Merged
merged 2 commits into from
Jun 13, 2023
Merged

test: remove usage of node-fetch #865

merged 2 commits into from
Jun 13, 2023

Conversation

wolfy1339
Copy link
Member

Closes #621

Resolves #ISSUE_NUMBER


Behavior

Before the change?

  • The tests would use node-fetch

After the change?

  • Drops node-fetch in favour of the Fetch API

Other information


Additional info

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Added the appropriate label for the given change

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes (Please add the Type: Breaking change label)
  • No

If Yes, what's the impact:

  • N/A

Pull request type

Please add the corresponding label for change this PR introduces:

  • Dependencies/code cleanup: Type: Maintenance

@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 12, 2023
@wolfy1339 wolfy1339 merged commit b920590 into main Jun 13, 2023
@wolfy1339 wolfy1339 deleted the remove-node-fetch branch June 13, 2023 18:56
@github-actions
Copy link
Contributor

🎉 This PR is included in version 12.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants