Remove lwt_ppx dependency
#815
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n-osborne
force-pushed
the
remove-ppx-lwt
branch
from
b9f9628 to
d46cc74
Compare
balat
reviewed
Mar 18, 2025
src/lib/eliom_form.eliom
Outdated
| let%lwt () = f v in | ||
| Lwt.return_true | ||
| | Some v -> let* () = f v in | ||
|
|
balat
reviewed
Mar 18, 2025
src/lib/eliom_shared.eliom
Outdated
| ignore (React.S.retain s (fun () -> ignore effectful_signal)); | ||
| Lwt.return_unit); | ||
| let* ss = th in | ||
|
|
There was a problem hiding this comment.
There seems to be a white line after many let*. And indentation is different. Did you ocamlformat everything?
There was a problem hiding this comment.
Sadly ocamlformat doesn't seem to remove those newlines. I've updated by hand.
n-osborne
force-pushed
the
remove-ppx-lwt
branch
2 times, most recently
from
22271f5 to
a52f88a
Compare
n-osborne
force-pushed
the
remove-ppx-lwt
branch
from
a52f88a to
a5ff4f1
Compare
balat
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes to get rid of the
%lwtsyntax fromlwt_ppxin favor of theLwt_syntax.It is based on #814, please consider only the last commit.
This is join work with @Julow (who wrote the tool making the automatic changes)
Most of the changes has been done automatically using the prototype tool
here. This is the reason why
the PR is one big commit.
This is a first step toward moving from Lwt to effect-based concurrency. The
idea is to homogenize the syntax in order to have less cases to handle (again
by an automatic tool).
This is also an independent contribution, as it removes one dependency and one
preprocessor. Which can be considered a win by itself.