Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputText: Implement double/triple-click + drag word/line selection #8032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

InputText: Implement double/triple-click + drag word/line selection #8032

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions imgui_internal.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1119,6 +1119,8 @@ struct IMGUI_API ImGuiInputTextState
bool ReloadUserBuf; // force a reload of user buf so it may be modified externally. may be automatic in future version.
int ReloadSelectionStart; // POSITIONS ARE IN IMWCHAR units *NOT* UTF-8 this is why this is not exposed yet.
int ReloadSelectionEnd;
int SelectionClicks; // double/triple-click word/line selection mode.
int SelectionOrigin; // char-index/cursor-position under the mouse click that started current selection.

ImGuiInputTextState();
~ImGuiInputTextState();
Expand Down
54 changes: 53 additions & 1 deletion imgui_widgets.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4631,6 +4631,9 @@ bool ImGui::InputTextEx(const char* label, const char* hint, char* buf, int buf_
const int multiclick_count = (io.MouseClickedCount[0] - 2);
if ((multiclick_count % 2) == 0)
{
state->SelectionClicks = 2;
state->SelectionOrigin = state->Stb->cursor;

// Double-click: Select word
// We always use the "Mac" word advance for double-click select vs CTRL+Right which use the platform dependent variant:
// FIXME: There are likely many ways to improve this behavior, but there's no "right" behavior (depends on use-case, software, OS)
Expand All @@ -4646,6 +4649,10 @@ bool ImGui::InputTextEx(const char* label, const char* hint, char* buf, int buf_
}
else
{
// No line-selection mode for single line, fallback to word selection
state->SelectionClicks = is_multiline ? 3 : 2;
state->SelectionOrigin = state->Stb->cursor;

// Triple-click: Select line
const bool is_eol = ImStb::STB_TEXTEDIT_GETCHAR(state, state->Stb->cursor) == '\n';
state->OnKeyPressed(STB_TEXTEDIT_K_LINESTART);
Expand Down Expand Up @@ -4673,12 +4680,57 @@ bool ImGui::InputTextEx(const char* label, const char* hint, char* buf, int buf_
}
else if (io.MouseDown[0] && !state->SelectedAllMouseLock && (io.MouseDelta.x != 0.0f || io.MouseDelta.y != 0.0f))
{
stb_textedit_drag(state, state->Stb, mouse_x, mouse_y);
if (state->SelectionClicks >= 2)
{
// Double/Triple-click + drag incremental word/line selection
int origin = state->SelectionOrigin;
int drag = ImStb::stb_text_locate_coord(state, mouse_x, mouse_y);

const bool swap = drag < origin;

if (swap)
ImSwap(drag, origin);

if (state->SelectionClicks == 2)
{
const bool move_left = !ImStb::is_word_boundary_from_right(state, origin);
state->Stb->select_start = move_left ? ImStb::STB_TEXTEDIT_MOVEWORDLEFT_IMPL(state, origin) : origin;

const bool move_right = !ImStb::is_word_boundary_from_left(state, drag);
state->Stb->select_end = move_right ? ImStb::STB_TEXTEDIT_MOVEWORDRIGHT_MAC(state, drag) : drag;
}
else if (state->SelectionClicks == 3)
{
while (origin > 0 && ImStb::STB_TEXTEDIT_GETCHAR(state, origin - 1) != ImStb::STB_TEXTEDIT_NEWLINE)
--origin;

int length = ImStb::STB_TEXTEDIT_STRINGLEN(state);
while (drag < length && ImStb::STB_TEXTEDIT_GETCHAR(state, drag) != ImStb::STB_TEXTEDIT_NEWLINE)
++drag;
if (drag != length)
++drag;

state->Stb->select_start = origin;
state->Stb->select_end = drag;
}

if (swap)
ImSwap(state->Stb->select_start, state->Stb->select_end);

state->Stb->cursor = state->Stb->select_end;
}
else
{
stb_textedit_drag(state, state->Stb, mouse_x, mouse_y);
}
state->CursorAnimReset();
state->CursorFollow = true;
}
if (state->SelectedAllMouseLock && !io.MouseDown[0])
state->SelectedAllMouseLock = false;
// End ongoing multi-click selection on mouse-up or selection text replace
if (state->SelectionClicks >= 2 && !(io.MouseDown[0] && state->HasSelection()))
state->SelectionClicks = 0;

// We expect backends to emit a Tab key but some also emit a Tab character which we ignore (#2467, #1336)
// (For Tab and Enter: Win32/SFML/Allegro are sending both keys and chars, GLFW and SDL are only sending keys. For Space they all send all threes)
Expand Down