Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[wiki] Add image loading and displaying example with WebGPU #8025

Closed
wants to merge 3 commits into from

Conversation

Jairard
Copy link

@Jairard Jairard commented Sep 29, 2024

Dummy PR to update wiki following this discussion. First commit is just importing the markdown file from the wiki, the following ones are the actual changes to review.

Please note that to match other examples, the screenshot should be uploaded to Github and its link should be changed.

@ocornut
Copy link
Owner

ocornut commented Sep 30, 2024

Thank you! I am pleasantly surprised that the git process worked here even though the PR is on imgui repo:
I used git fetch xxx then git cherry-pick xxx in my local version of wiki repo and could merge the commits perfectly!

@ocornut ocornut closed this Sep 30, 2024
@Jairard Jairard deleted the wiki.webgpu_image branch September 30, 2024 11:13
@Jairard
Copy link
Author

Jairard commented Sep 30, 2024

Perfect ! It looks like the image is broken though

@ocornut
Copy link
Owner

ocornut commented Sep 30, 2024

Fixed it. Not sure what happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants