-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/refactor_access_lists #879
Conversation
*/ | ||
|
||
function initialize( | ||
address owner_, |
Check notice
Code scanning / Slither
Missing zero address validation Low
- owner = owner
string calldata symbol_, | ||
bool transferable_, | ||
address[] memory user, | ||
string[] memory _tokenURI |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
function _isContract(address account) internal view returns (bool) { | ||
// This method relies on extcodesize, which returns 0 for contracts in | ||
// construction, since the code is only stored at the end of the | ||
// constructor execution. | ||
|
||
uint256 size; | ||
// solhint-disable-next-line no-inline-assembly | ||
assembly { | ||
size := extcodesize(account) | ||
} | ||
return size > 0; | ||
} |
Check warning
Code scanning / Slither
Assembly usage Warning
string calldata name, | ||
string calldata symbol, | ||
bool transferable, | ||
address owner, |
Check notice
Code scanning / Slither
Local variable shadowing Low
bool transferable, | ||
address owner, | ||
address[] memory user, | ||
string[] memory _tokenURI |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
*/ | ||
|
||
// function to activate a disabled token. | ||
function changeTemplateAddress(address _newTemplateAddress) external onlyOwner { |
Check warning
Code scanning / Slither
Conformance to Solidity naming conventions Warning
function isSoulBound(address contractAddress) external view returns (bool){ | ||
require(isDeployed(contractAddress)==true,"Not deployed by factory"); | ||
return(!(IAccessList(contractAddress).transferable())); | ||
} |
Check warning
Code scanning / Slither
Boolean equality Warning
-require(bool,string)(isDeployed(contractAddress) == true,Not deployed by factory)
Feature/refactor_access_lists
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
Changes proposed in this PR: