Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add booster for rewards #867

Merged
merged 3 commits into from
Aug 13, 2024
Merged

add booster for rewards #867

merged 3 commits into from
Aug 13, 2024

Conversation

alexcos20
Copy link
Member

Add booster contract for upcoming node rewards

@alexcos20 alexcos20 self-assigned this Jun 27, 2024
/**
* @notice Batch Mint only for owner
*/
function batchCreateBoosts(address[] memory user,string[] memory tokenURI) external onlyOwner

Check notice

Code scanning / Slither

Local variable shadowing Low

return newItemId;
}

function createBoost(address user, string memory tokenURI) external onlyOwner returns (uint256) {

Check notice

Code scanning / Slither

Local variable shadowing Low

using Counters for Counters.Counter;
Counters.Counter private _tokenIds;
uint256 public boost;
constructor(string memory _name, string memory _symbol,uint256 _boost)

Check notice

Code scanning / Slither

Local variable shadowing Low

using Counters for Counters.Counter;
Counters.Counter private _tokenIds;
uint256 public boost;
constructor(string memory _name, string memory _symbol,uint256 _boost)

Check notice

Code scanning / Slither

Local variable shadowing Low

super._beforeTokenTransfer(from, to, tokenId, batchSize);
}

function _createBoost(address user, string memory tokenURI) private returns (uint256) {

Check notice

Code scanning / Slither

Local variable shadowing Low

Comment on lines 80 to 82
function _burn(uint256 tokenId) internal override(ERC721URIStorage,ERC721) {
revert("Burning not allowed");
}

Check warning

Code scanning / Slither

Dead-code Warning

Booster._burn(uint256) is never used and should be removed
contracts/rewards/Booster.sol Fixed Show fixed Hide fixed
contracts/rewards/Booster.sol Fixed Show fixed Hide fixed
Copy link

openzeppelin-code bot commented Jun 27, 2024

add booster for rewards

Generated at commit: 170039009414fef45f9f0a69c37caaeb40bd1704

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total
2
1
0
10
39
52
Dependencies Critical
High
Medium
Low
Note
Total
0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@alexcos20 alexcos20 requested a review from mihaisc June 28, 2024 13:01
@alexcos20 alexcos20 marked this pull request as ready for review June 28, 2024 13:03
@alexcos20 alexcos20 requested a review from trentmc as a code owner June 28, 2024 13:03
Copy link
Member

@trentmc trentmc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comments that I gave for the access list pr

@alexcos20 alexcos20 changed the base branch from main to release/v2.1.0 August 13, 2024 08:24
@alexcos20 alexcos20 merged commit 1e7e269 into release/v2.1.0 Aug 13, 2024
9 checks passed
@alexcos20 alexcos20 deleted the feature/booster_rewards branch August 13, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants