Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chain_id to chainId #1098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Change chain_id to chainId #1098

wants to merge 1 commit into from

Conversation

3xz1
Copy link

@3xz1 3xz1 commented Feb 12, 2024

Description

Fixes the bug in the trigger_caching function where the incorrect key (chain_id) was used instead of the correct key (chainId) to extract the chainId value from the request payload.

Is this PR related with an open issue?

Related to Issue Related to Issue 1097. The issue is located in the aquarius/app/assets.py file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Follows the code style of this project.
  • Tests Cover Changes
  • Documentation

@mariacarmina
Copy link
Member

Hello @3xz1, on API.md check Valid body section. We need to update the table. In the table the parameters are with camelcase, but in Valid body it is shown as chain_id.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants