Optimize tenant backup and restore #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d to Name of CustomResource
…with backup or archive path
| @@ -30,8 +30,8 @@ type OBTenantBackupPolicySpec struct { | |||
| // Important: Run "make" to regenerate code after modifying this file | |||
|
|
|||
| ObClusterName string `json:"obClusterName"` | |||
| TenantName string `json:"tenantName"` | |||
| TenantSecret string `json:"tenantSecret"` | |||
| TenantName string `json:"tenantName"` // Name of obtenant resource | |||
There was a problem hiding this comment.
is this the tenant name in obcluster or cr's name, the previous implementation is tenant name in obcluster
There was a problem hiding this comment.
The field had been changed to refer to name of CR in commit 6966330
| @@ -69,6 +69,10 @@ func (c *Coordinator) Coordinate() (ctrl.Result, error) { | |||
| return result, errors.Wrapf(err, "Check and update finalizer failed") | |||
| } | |||
| } | |||
| err = c.cleanTaskResultMap(f) | |||
There was a problem hiding this comment.
this is already fixed in the release branch, maybe it's better to merge the branch before develop next time
There was a problem hiding this comment.
OK, I will merge the branch 2.0.0_relase
It SHOULD NOT be compatible with branch |
|
Optimize backup and restore progress #41 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
backupPolicy.tenantNamefrom tenant_name ofDBA_OB_TENANTdatabase view to tenantName ofOBTenantCRDOSS,ossAccessSecretfield become required indestinationwhich reference a k8s secret resource containing access_id and access_key that will be used in accessing OSSinclude make/*.mk